From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8CF6C433FE for ; Thu, 10 Dec 2020 12:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C4DF23C82 for ; Thu, 10 Dec 2020 12:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730941AbgLJMXl (ORCPT ); Thu, 10 Dec 2020 07:23:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48298 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729976AbgLJMXg (ORCPT ); Thu, 10 Dec 2020 07:23:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607602928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7PSrzA8rIkZ91gYxwlJNdk5yQ9KUFigi9bQ/KRmwMkM=; b=JO0uVZism5S7+vnQuEfo5UV3rO3rhFVCYs/dOHzHEDv0Q0vxl9n/KN2jw3n45jkBUQb94I TJ4zW7LT2pwflkyCBQAsrGFALXI1hlNNRY9QfPJrR3UOXfJicktvEFA9TFaKlbKt2Xx+sC quLWNh1brjNVeTYxEsbPD67OJIsQSAM= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-EAQrkjCWP0Ssv6W344nMug-1; Thu, 10 Dec 2020 07:22:06 -0500 X-MC-Unique: EAQrkjCWP0Ssv6W344nMug-1 Received: by mail-ed1-f72.google.com with SMTP id dh21so2351067edb.6 for ; Thu, 10 Dec 2020 04:22:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7PSrzA8rIkZ91gYxwlJNdk5yQ9KUFigi9bQ/KRmwMkM=; b=bmzk1c4rg4YhzqF/g2qyXSGP+eIM/zc8MLSwn0TM1EVlks6BmniWKCVgFeV4Bex53D W52Rc3tppFwEXlnYfaTQLGJCwQ2wO/G86djWEsdR/9oJ1Iokw748VNkWvBC0RmvVEJHA iMFBKnE1CVzEETUJeSaAluXBtyxV73GQsYuE/XSHwb5a2hyDHub0NLlRrD3LU2F2MjsL 6BNihXuksPgfHQ16UjYfu/H5dX1dkioDxJF7SVPs823EMxEaxEqa0aLiuZnqJTWzksqw twiwcwsdfce2K3tMVzQ8U94gii00k1xmXFyIgPSoQW+WhneeRLly9LNwPXhfJHRvXova 1dnw== X-Gm-Message-State: AOAM5320fdqBoNk83QwZcWx/DaTSvCDeWquyLbi1iaPGuaP29bkFj9oI tIoMewhpBwXAjlGNRp8V05YEXY0/p2Wnw9USsuVd5BWWAG0LhrTuxZD8axLE1SQfrKfSmdkNR6Y auc0wah6E830eN7pkbtbKnIfp X-Received: by 2002:aa7:cf85:: with SMTP id z5mr6509202edx.274.1607602925125; Thu, 10 Dec 2020 04:22:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJybequ2MuYAvUJlcvYBoDwmZDe57QoKmulE84b6L8d93gCq/hTPU3F6HevqVt9BG7Kzyoq87w== X-Received: by 2002:aa7:cf85:: with SMTP id z5mr6509198edx.274.1607602924980; Thu, 10 Dec 2020 04:22:04 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id h15sm4492763ejq.29.2020.12.10.04.22.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Dec 2020 04:22:04 -0800 (PST) Subject: Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE To: Peter Zijlstra Cc: Thomas Gleixner , Vitaly Kuznetsov , Maxim Levitsky , "H. Peter Anvin" , Jonathan Corbet , Jim Mattson , Wanpeng Li , "open list:KERNEL SELFTEST FRAMEWORK" , Marcelo Tosatti , Sean Christopherson , open list , Ingo Molnar , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Joerg Roedel , Borislav Petkov , Shuah Khan , Andrew Jones , Oliver Upton , "open list:DOCUMENTATION" , kvm@vger.kernel.org References: <20201203171118.372391-1-mlevitsk@redhat.com> <20201203171118.372391-2-mlevitsk@redhat.com> <87a6uq9abf.fsf@nanos.tec.linutronix.de> <1dbbeefc7c76c259b55582468ccd3aab35a6de60.camel@redhat.com> <87im9dlpsw.fsf@vitty.brq.redhat.com> <875z5d5x9m.fsf@nanos.tec.linutronix.de> <20201210121417.GN2414@hirez.programming.kicks-ass.net> From: Paolo Bonzini Message-ID: Date: Thu, 10 Dec 2020 13:22:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201210121417.GN2414@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/20 13:14, Peter Zijlstra wrote: > On Thu, Dec 10, 2020 at 12:42:36PM +0100, Paolo Bonzini wrote: >> On 07/12/20 18:41, Thomas Gleixner wrote: >>> Right this happens still occasionally, but for quite some time this is >>> 100% firmware sillyness and not a fundamental property of the hardware >>> anymore. >> >> It's still a fundamental property of old hardware. Last time I tried to >> kill support for processors earlier than Core 2, I had to revert it. That's >> older than Nehalem. > > Core2 doesn't use TSC for timekeeping anyway. KVM shouldn't either. On Core2, KVM guests pass TSC through kvmclock in order to get something usable and not incredibly slow. Paolo