From: Stefan Roese <sr@denx.de>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Cc: matthias.bgg@gmail.com, wsa@the-dreams.de, christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH -next v2 1/2] i2c: mt7621: fix missing clk_disable_unprepare() on error in mtk_i2c_probe()
Date: Mon, 16 May 2022 08:26:20 +0200 [thread overview]
Message-ID: <fe4d398e-978c-6784-e3f6-01b83da3f249@denx.de> (raw)
In-Reply-To: <20220514023148.305457-1-yangyingliang@huawei.com>
On 14.05.22 04:31, Yang Yingliang wrote:
> Fix the missing clk_disable_unprepare() before return
> from mtk_i2c_probe() in the error handling case.
>
> Fixes: d04913ec5f89 ("i2c: mt7621: Add MediaTek MT7621/7628/7688 I2C driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> v2: add return 0 in normal path.
> ---
> drivers/i2c/busses/i2c-mt7621.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt7621.c b/drivers/i2c/busses/i2c-mt7621.c
> index 45fe4a7fe0c0..901f0fb04fee 100644
> --- a/drivers/i2c/busses/i2c-mt7621.c
> +++ b/drivers/i2c/busses/i2c-mt7621.c
> @@ -304,7 +304,8 @@ static int mtk_i2c_probe(struct platform_device *pdev)
>
> if (i2c->bus_freq == 0) {
> dev_warn(i2c->dev, "clock-frequency 0 not supported\n");
> - return -EINVAL;
> + ret = -EINVAL;
> + goto err_disable_clk;
> }
>
> adap = &i2c->adap;
> @@ -322,10 +323,15 @@ static int mtk_i2c_probe(struct platform_device *pdev)
>
> ret = i2c_add_adapter(adap);
> if (ret < 0)
> - return ret;
> + goto err_disable_clk;
>
> dev_info(&pdev->dev, "clock %u kHz\n", i2c->bus_freq / 1000);
>
> + return 0;
> +
> +err_disable_clk:
> + clk_disable_unprepare(i2c->clk);
> +
> return ret;
> }
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2022-05-16 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 2:31 [PATCH -next v2 1/2] i2c: mt7621: fix missing clk_disable_unprepare() on error in mtk_i2c_probe() Yang Yingliang
2022-05-14 2:31 ` [PATCH -next v2 2/2] i2c: mt7621: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2022-05-21 10:13 ` Wolfram Sang
2022-05-16 6:26 ` Stefan Roese [this message]
2022-05-21 10:12 ` [PATCH -next v2 1/2] i2c: mt7621: fix missing clk_disable_unprepare() on error in mtk_i2c_probe() Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe4d398e-978c-6784-e3f6-01b83da3f249@denx.de \
--to=sr@denx.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=wsa@the-dreams.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).