From: Markus Elfring <Markus.Elfring@web.de>
To: linux-tegra@vger.kernel.org, JC Kuo <jckuo@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Thierry Reding <treding@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Kangjie Lu <kjlu@umn.edu>,
Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>
Subject: phy: tegra: xusb: Complete exception handling in five probe functions
Date: Mon, 28 Oct 2019 22:20:25 +0100 [thread overview]
Message-ID: <fe6868a4-01f5-2832-9081-7643be0ab4a1@web.de> (raw)
Hello,
I have taken another look also at the implementations of five probe functions.
I have got the impression then that the exception handling is incomplete so far
at these source code places.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/phy/tegra/xusb-tegra124.c#L608
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/tegra/xusb-tegra124.c?id=8005803a2ca0af49f36f6e9329b5ecda3df27347#n608
How do you think about to move kfree() calls to other jump targets
according to the Linux coding style?
Regards,
Markus
next reply other threads:[~2019-10-28 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 21:20 Markus Elfring [this message]
2019-10-29 9:40 ` phy: tegra: xusb: Complete exception handling in probe functions Markus Elfring
2019-10-30 10:44 ` drivers/phy/tegra: Completion for exception handling in probe functions with SmPL? Markus Elfring
2019-10-30 20:50 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe6868a4-01f5-2832-9081-7643be0ab4a1@web.de \
--to=markus.elfring@web.de \
--cc=emamd001@umn.edu \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@ti.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smccaman@umn.edu \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).