From: Steven Price <steven.price@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Mark Rutland" <Mark.Rutland@arm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
linux-mm@kvack.org, "Albert Ou" <aou@eecs.berkeley.edu>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-riscv@lists.infradead.org, "Will Deacon" <will@kernel.org>,
"Liang, Kan" <kan.liang@linux.intel.com>,
"Alexandre Ghiti" <alex@ghiti.fr>,
x86@kernel.org, "Ingo Molnar" <mingo@redhat.com>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Andy Lutomirski" <luto@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org, "James Morse" <james.morse@arm.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v12 07/22] riscv: mm: Add p?d_leaf() definitions
Date: Fri, 18 Oct 2019 17:20:30 +0100 [thread overview]
Message-ID: <fe6a0fe4-e789-fb4b-4481-b3934234e16f@arm.com> (raw)
In-Reply-To: <20191018155743.GG25386@infradead.org>
On 18/10/2019 16:57, Christoph Hellwig wrote:
>> + return pud_present(pud)
>> + && (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC));
>> +}
>
> The operators always need to go before the line break, not after it
> per linux coding style. There are a few more spots like this, so please
> audit the whole series for it.
Fair enough. In this case I was just copying the example in pte_huge()
that already existed - but you're right this isn't the kernel coding style.
Thanks,
Steve
next prev parent reply other threads:[~2019-10-18 16:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 10:12 [PATCH v12 00/22] Generic page walk and ptdump Steven Price
2019-10-18 10:12 ` [PATCH v12 01/22] mm: Add generic p?d_leaf() macros Steven Price
2019-10-18 10:12 ` [PATCH v12 02/22] arc: mm: Add p?d_leaf() definitions Steven Price
2019-10-18 10:12 ` [PATCH v12 03/22] arm: " Steven Price
2019-10-18 10:12 ` [PATCH v12 04/22] arm64: " Steven Price
2019-10-18 10:12 ` [PATCH v12 05/22] mips: " Steven Price
2019-10-18 10:12 ` [PATCH v12 06/22] powerpc: " Steven Price
2019-10-18 10:12 ` [PATCH v12 07/22] riscv: " Steven Price
2019-10-18 15:57 ` Christoph Hellwig
2019-10-18 16:20 ` Steven Price [this message]
2019-10-18 10:12 ` [PATCH v12 08/22] s390: " Steven Price
2019-10-18 10:12 ` [PATCH v12 09/22] sparc: " Steven Price
2019-10-18 10:12 ` [PATCH v12 10/22] x86: " Steven Price
2019-10-18 10:12 ` [PATCH v12 11/22] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price
2019-10-24 13:06 ` Zong Li
2019-10-18 10:12 ` [PATCH v12 12/22] mm: pagewalk: Allow walking without vma Steven Price
2019-10-24 13:05 ` Zong Li
2019-10-18 10:12 ` [PATCH v12 13/22] mm: pagewalk: Add test_p?d callbacks Steven Price
2019-10-24 13:06 ` Zong Li
2019-10-18 10:12 ` [PATCH v12 14/22] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price
2019-10-24 13:07 ` Zong Li
2019-10-18 10:12 ` [PATCH v12 15/22] x86: mm: Point to struct seq_file from struct pg_state Steven Price
2019-10-18 10:12 ` [PATCH v12 16/22] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price
2019-10-18 10:12 ` [PATCH v12 17/22] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price
2019-10-18 10:12 ` [PATCH v12 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price
2019-10-18 10:12 ` [PATCH v12 19/22] mm: Add generic ptdump Steven Price
2019-10-18 10:12 ` [PATCH v12 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price
2019-10-18 10:12 ` [PATCH v12 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price
2019-10-18 10:12 ` [PATCH v12 22/22] arm64: mm: Display non-present entries in ptdump Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe6a0fe4-e789-fb4b-4481-b3934234e16f@arm.com \
--to=steven.price@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jglisse@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).