From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] nvmem: meson: efuse updates
Date: Mon, 12 Nov 2018 13:08:49 +0000 [thread overview]
Message-ID: <fe93e6da-e55f-f127-32c2-5f0e46421b7b@linaro.org> (raw)
In-Reply-To: <20181030102231.4851-1-jbrunet@baylibre.com>
On 30/10/18 10:22, Jerome Brunet wrote:
> The first change of this patchset just adds add error message in case
> of failure. If there is problem with the secure monitor, the
> SM_EFUSE_USER_MAX call will be first one to fail so it is better if it
> give us a clue to help debugging, instead af silently failing.
>
> Next this series adds the peripheral clock missing in this driver.
> Like many other device in amlogic's SoC, the efuse requires a
> peripheral clock to operate. ATM, the clock controller has
> CLK_IGNORE_UNUSED on this clock and we have been lucky enough that the
> bootloader left the clock enabled
>
> At some point, we would like to remove those CLK_IGNORE_UNUSED, so if a
> driver needs a clock, it needs to properly claim it.
>
> Srinivas, Kevin,
> The dts change needs to land before the actual driver change, to avoid
> breaking the efuse on our users. If there an agreement on this series,
> Kevin could you provide a tag to Srinivas ?
These are not fixes to any bugs/regressions, so its new material which
can only go in next dev cycle!
I guess that should also address the patch sequencing issue!
Also I need ack from dt-maintaners on clk bindings to pick patch 2 and 4.
thanks,
srini
>
> Cheers
> Jerome
next prev parent reply other threads:[~2018-11-12 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 10:22 [PATCH 0/4] nvmem: meson: efuse updates Jerome Brunet
2018-10-30 10:22 ` [PATCH 1/4] nvmem: meson-efuse: add error message on user_max failure Jerome Brunet
2018-11-12 13:08 ` Srinivas Kandagatla
2018-10-30 10:22 ` [PATCH 2/4] nvmem: meson-efuse: bindings: add peripheral clock Jerome Brunet
2018-11-13 9:05 ` Srinivas Kandagatla
2018-10-30 10:22 ` [PATCH 3/4] arm64: dts: meson-gx: add efuse pclk Jerome Brunet
2018-10-30 10:22 ` [PATCH 4/4] nvmem: meson-efuse: add peripheral clock Jerome Brunet
2018-11-13 9:06 ` Srinivas Kandagatla
2018-11-12 13:08 ` Srinivas Kandagatla [this message]
2018-11-12 13:28 ` [PATCH 0/4] nvmem: meson: efuse updates jbrunet
2018-11-12 13:34 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe93e6da-e55f-f127-32c2-5f0e46421b7b@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).