From: Florian Fainelli <f.fainelli@gmail.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
davem@davemloft.net, kuba@kernel.org,
bcm-kernel-feedback-list@broadcom.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] bcm63xx_enet: remove needless variable definitions
Date: Wed, 28 Jul 2021 09:14:53 -0700 [thread overview]
Message-ID: <fe95911f-b701-f241-c5a2-af8042c9b238@gmail.com> (raw)
In-Reply-To: <20210728132456.2540-1-tangbin@cmss.chinamobile.com>
On 7/28/2021 6:24 AM, Tang Bin wrote:
> In the function bcm_enetsw_probe(), 'ret' will be assigned by
> bcm_enet_change_mtu(), so 'ret = 0' make no sense.
You are not removing the variable definition or declaration, you are
removing a redundant assignment which is a different thing. I do agree
with the rationale however, so please fix up the subject and I will add
my Acked-by to this patch. Thanks!
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 916824cca..509e10013 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -2646,7 +2646,6 @@ static int bcm_enetsw_probe(struct platform_device *pdev)
> if (!res_mem || irq_rx < 0)
> return -ENODEV;
>
> - ret = 0;
> dev = alloc_etherdev(sizeof(*priv));
> if (!dev)
> return -ENOMEM;
>
--
Florian
prev parent reply other threads:[~2021-07-28 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 13:24 [PATCH] bcm63xx_enet: remove needless variable definitions Tang Bin
2021-07-28 16:14 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe95911f-b701-f241-c5a2-af8042c9b238@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).