From: Xiubo Li <xiubli@redhat.com>
To: Mike Christie <mchristi@redhat.com>,
josef@toxicpanda.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v3] nbd: fix possible page fault for nbd disk
Date: Fri, 30 Aug 2019 13:22:31 +0800 [thread overview]
Message-ID: <fe964fbe-64fe-5bf3-25e9-9e76175d7eba@redhat.com> (raw)
In-Reply-To: <78d16d10-1d06-6ce1-7c51-64c42e51f549@redhat.com>
On 2019/8/30 8:58, Xiubo Li wrote:
> On 2019/8/30 7:49, Mike Christie wrote:
>> On 08/22/2019 02:59 AM, xiubli@redhat.com wrote:
[...]
>>
>>> + test_bit(NBD_DISCONNECT_REQUESTED, &nbd->flags)) {
>>> + mutex_unlock(&nbd_index_mutex);
>>> +
>>> + /* Wait untill the recv_work exit */
>> If that is all you need we could do a flush_workqueue(nbd->recv_workq)
>> (you would need Jens's for next branch which has some work queue changes
>> in nbd).
>
> Yeah, this makes sense.
This has already been done in nbd_disconnect_and_put() in the Jen's for
next branch code. So here it will make no sense.
I will rebase this patch set to that branch.
Thanks.
BRs
Xiubo
next prev parent reply other threads:[~2019-08-30 5:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 7:59 [PATCH 0/2 v3] nbd: fix possible page fault for nbd disk xiubli
2019-08-22 7:59 ` [PATCH 1/2 v3] nbd: rename the runtime flags as NBD_RT_ prefixed xiubli
2019-08-22 7:59 ` [PATCH 2/2 v3] nbd: fix possible page fault for nbd disk xiubli
2019-08-29 23:49 ` Mike Christie
2019-08-30 0:58 ` Xiubo Li
2019-08-30 5:22 ` Xiubo Li [this message]
2019-09-02 21:30 ` Mike Christie
2019-09-03 0:45 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe964fbe-64fe-5bf3-25e9-9e76175d7eba@redhat.com \
--to=xiubli@redhat.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nbd@other.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).