linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "arm@kernel.org" <arm@kernel.org>,
	Olof Johansson <olof@lixom.net>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Murali Karicheri <m-karicheri2@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Sekhar Nori <nsekhar@ti.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"David S . Miller" <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Andrew Lunn <andrew@lunn.ch>,
	Philippe Schenker <philippe.schenker@toradex.com>
Subject: Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
Date: Sat, 25 Jul 2020 13:56:50 -0700	[thread overview]
Message-ID: <feaa8f63-319a-1c3a-fcdd-804e74bbc8ec@oracle.com> (raw)
In-Reply-To: <CAK8P3a3N70PbotC18K-SG9+XgfApHNZyCYvUgOyfrxrP55zSEw@mail.gmail.com>

On 7/25/20 12:57 AM, Arnd Bergmann wrote:
> On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@oracle.com
> <santosh.shilimkar@oracle.com> wrote:
>> On 7/24/20 2:42 PM, Grygorii Strashko wrote:
>>> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
>>> KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
>>>
>>> The above board have phy-mode = "rgmii-id" and it is worked before because
>>> KSZ9031 PHY started with default RGMII internal delays configuration (TX
>>> off, RX on 1.2 ns) and MAC provided TX delay by default.
>>> After above commit, the KSZ9031 PHY starts handling phy mode properly and
>>> enables both RX and TX delays, as result networking is become broken.
>>>
>>> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
>>> behavior.
>>>
>>> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>>> Cc: Andrew Lunn <andrew@lunn.ch>
>>> Cc: Philippe Schenker <philippe.schenker@toradex.com>
>>> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>> ---
>>> Fix for one more broken TI board with KSZ9031 PHY.
>> Can you please apply this patch to your v5.8 fixes branch and send it
>> upstream ? Without the fix K2G EVM board is broken with v5.8.
>>
>> Am hoping you can pick this up with pull request since it just one
>> patch.
> 
> I've applied it now, but would point out that it's generally better if you could
> forward the patch to soc@kernel.org with your Signed-off-by if you come
> across a similar patch again. That way it ends up in patchwork, and we
> are more likely to pick it up quickly.
> 
Will do next time. Thanks for picking it up.
Regards,
Santosh

      reply	other threads:[~2020-07-25 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 21:42 [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy Grygorii Strashko
2020-07-24 21:55 ` santosh.shilimkar
2020-07-25  7:57   ` Arnd Bergmann
2020-07-25 20:56     ` santosh.shilimkar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feaa8f63-319a-1c3a-fcdd-804e74bbc8ec@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=andrew@lunn.ch \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=o.rempel@pengutronix.de \
    --cc=olof@lixom.net \
    --cc=philippe.schenker@toradex.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).