From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443B1C282CE for ; Tue, 4 Jun 2019 15:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 217C920843 for ; Tue, 4 Jun 2019 15:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728219AbfFDPVw (ORCPT ); Tue, 4 Jun 2019 11:21:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbfFDPVw (ORCPT ); Tue, 4 Jun 2019 11:21:52 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 87F6D2F8BC8; Tue, 4 Jun 2019 15:21:46 +0000 (UTC) Received: from ovpn-112-67.rdu2.redhat.com (ovpn-112-67.rdu2.redhat.com [10.10.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23E621001947; Tue, 4 Jun 2019 15:21:41 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver From: Dan Williams To: Subash Abhinov Kasiviswanathan Cc: Alex Elder , Arnd Bergmann , David Miller , Bjorn Andersson , Ilias Apalodimas , evgreen@chromium.org, Ben Chan , Eric Caruso , cpratapa@codeaurora.org, syadagir@codeaurora.org, abhishek.esse@gmail.com, Networking , DTML , Linux Kernel Mailing List , linux-soc@vger.kernel.org, Linux ARM , linux-arm-msm@vger.kernel.org Date: Tue, 04 Jun 2019 10:21:41 -0500 In-Reply-To: References: <20190531035348.7194-1-elder@linaro.org> <065c95a8-7b17-495d-f225-36c46faccdd7@linaro.org> <3b1e12b145a273dd3ded2864d976bdc5fa90e68a.camel@redhat.com> <87f98f81-8f77-3bc5-374c-f498e07cb1bd@linaro.org> <0fc29577a5c69530145b6095fa1ac1a51949ba8e.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 04 Jun 2019 15:21:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-06-03 at 13:04 -0600, Subash Abhinov Kasiviswanathan wrote: > > > I can't (or won't) comment right now on whether IPA needs its own > > > netdev for rmnet to use. The IPA endpoints used for the modem > > > network interfaces are enabled when the netdev is opened and > > > disabled when closed. Outside of that, TX and RX are pretty > > > much immediately passed through to the layer below or above. > > > IPA currently has no other net device operations. > > > > I don't really have issues with the patchset underneath the netdev > > layer. I'm interested in how the various bits present themselves to > > userspace, which is why I am trying to tie this in with Johannes' > > conversation about WWAN devices, netdevs, channels, and how the > > various > > drivers present API for creating data channels that map to > > different > > modem contexts. > > > > So let me rephrase. If the control plane has set up the default > > context > > and sent a QMI Start Network message (or the network attached the > > default one) and the resulting IP details are applied to the IPA > > netdev > > can things just start sending data? Or do we need to create an > > rmnet on > > top to get that working? > > > > Dan > > Hi Dan > > All data from the hardware will have the MAP headers. > We still need to create rmnet devs over the IPA netdev and use it > for > the > data path. > The IPA netdev will pass on the packets which it receives from the > hardware > and queue it to network stack where it will be intercepted by the > rmnet rx handler. Ok, so IPA only needs a netdev so that rmnet has something to send/receive packets to/from? This gets even closer to the discussion in "cellular modem driver APIs - take 2" from last week. Dan