From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Andy Gross <andy.gross@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 4/9] media: venus: adding core part and helper functions
Date: Wed, 8 Feb 2017 17:01:54 +0200 [thread overview]
Message-ID: <feb3efb6-dbda-b16a-477c-f36292b94f27@linaro.org> (raw)
In-Reply-To: <20170207233202.GI27837@minitux>
Bjorn, thanks for the comments!
On 02/08/2017 01:32 AM, Bjorn Andersson wrote:
> On Tue 07 Feb 05:10 PST 2017, Stanimir Varbanov wrote:
>
>> * firmware loader
>>
>
> I like the way this turns out, just some style comments below.
>
> [..]
>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
>> new file mode 100644
>> index 000000000000..4057696abaf5
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/venus/firmware.c
>> @@ -0,0 +1,151 @@
>> +/*
>> + * Copyright (C) 2017 Linaro Ltd.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 and
>> + * only version 2 as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + */
>> +
>> +#include <linux/dma-mapping.h>
>> +#include <linux/firmware.h>
>> +#include <linux/kernel.h>
>> +#include <linux/of.h>
>> +#include <linux/of_reserved_mem.h>
>> +#include <linux/slab.h>
>> +#include <linux/qcom_scm.h>
>> +#include <linux/soc/qcom/mdt_loader.h>
>> +
>> +#define VENUS_FIRMWARE_NAME "venus.mdt"
>> +#define VENUS_PAS_ID 9
>> +#define VENUS_FW_MEM_SIZE SZ_8M
>> +
>> +struct firmware_mem {
>> + struct device dev;
>> + void *mem_va;
>> + phys_addr_t mem_phys;
>> + size_t mem_size;
>> +};
>> +
>> +static struct firmware_mem fw;
>
> Rather than operating on a global variable I think you should either
> return your firmware_mem pointer or the device pointer to the caller of
> venus_boot() and have the core pass that back into venus_shutdown().
I will take your comments and will pass struct device *fw_dev as an
argument of venus_boot. Also I will move memory allocation in venus_boot
and by that way I don't need to keep memory attributes from above structure.
--
regards,
Stan
next prev parent reply other threads:[~2017-02-08 15:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:10 [PATCH v6 0/9] Qualcomm video decoder/encoder driver Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 2/9] doc: DT: venus: binding document for Qualcomm video driver Stanimir Varbanov
2017-02-22 0:09 ` Rob Herring
2017-02-22 9:25 ` Stanimir Varbanov
2017-02-22 14:17 ` Rob Herring
2017-02-23 13:08 ` Stanimir Varbanov
2017-02-23 13:16 ` Rob Herring
2017-02-07 13:10 ` [PATCH v6 3/9] MAINTAINERS: Add Qualcomm Venus video accelerator driver Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 4/9] media: venus: adding core part and helper functions Stanimir Varbanov
2017-02-07 23:32 ` Bjorn Andersson
2017-02-08 15:01 ` Stanimir Varbanov [this message]
2017-02-07 13:10 ` [PATCH v6 5/9] media: venus: vdec: add video decoder files Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 6/9] media: venus: venc: add video encoder files Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 7/9] media: venus: hfi: add Host Firmware Interface (HFI) Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 8/9] media: venus: hfi: add Venus HFI files Stanimir Varbanov
2017-02-07 13:10 ` [PATCH v6 9/9] media: venus: enable building of Venus video driver Stanimir Varbanov
2017-02-07 22:38 ` kbuild test robot
2017-02-09 13:38 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb3efb6-dbda-b16a-477c-f36292b94f27@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).