From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE86C48BE5 for ; Thu, 17 Jun 2021 01:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 677DD613DB for ; Thu, 17 Jun 2021 01:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231750AbhFQBDF (ORCPT ); Wed, 16 Jun 2021 21:03:05 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:11041 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231628AbhFQBDF (ORCPT ); Wed, 16 Jun 2021 21:03:05 -0400 Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G53ZJ6ZvNzZdgG; Thu, 17 Jun 2021 08:58:00 +0800 (CST) Received: from [10.67.100.138] (10.67.100.138) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 17 Jun 2021 09:00:56 +0800 Subject: Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue To: Andrew Lunn , Guangbin Huang CC: , , , , , , References: <1623836037-26812-1-git-send-email-huangguangbin2@huawei.com> <1623836037-26812-6-git-send-email-huangguangbin2@huawei.com> From: "lipeng (Y)" Message-ID: Date: Thu, 17 Jun 2021 09:00:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.138] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/6/17 0:20, Andrew Lunn 写道: >> static int cp_table[EVENTS][STATES] = { >> /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED >> - 0 1 2 3 4 5 6 */ >> + * 0 1 2 3 4 5 6 >> + */ >> {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */ >> { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */ >> { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */ > This probably reduces the readability of the code. So i would not make > this change. > > Please remember these are only guidelines. Please don't blindly make > changes, or change it because some bot says so. Check that it actually > makes sense and the code is better afterwards. > > Andrew > . Agree with you they are only guidelines. The code should  follow the rules mostly, or  it will be diferent style from different developer. If that's the exception, i will drop this patch. Thanks             Peng Li