From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: akpm@linux-foundation.org, mhocko@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
pasha.tatashin@soleen.com
Subject: Re: [PATCH 1/5] mm: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
Date: Tue, 12 Jan 2021 11:12:30 +0100 [thread overview]
Message-ID: <feef406c-105c-138a-b8af-345684876e25@redhat.com> (raw)
In-Reply-To: <20210112072643.GA10774@linux>
On 12.01.21 08:26, Oscar Salvador wrote:
> On Mon, Jan 11, 2021 at 05:52:19PM +0100, David Hildenbrand wrote:
>> On 17.12.20 14:07, Oscar Salvador wrote:
>>> In order to use self-hosted memmap array, the platform needs to have
>>> support for CONFIG_SPARSEMEM_VMEMMAP and altmap.
>>> Currently, only arm64, PPC and x86_64 have the support, so enable those
>>> platforms with ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE.
>>
>> "In the first version, only .... will support it".
>
> I will try to be more specific.
>
>>
>> I'd probably split off enabling it per architecture in separate patches
>> and the end of the series.
>
> You mean introducing only mm/Kconfig change in this patch, and then
> arch/*/Kconfig changes in separate patches at the end of the series?
Yeah, or squashing the leftovers of this patch (3 LOC) into patch #2.
>
> I can certainly do that, not sure how much will help with the review,
> but it might help when bisecting.
It's usually nicer to explicitly enable stuff per architecture, stating
why it works on that architecture (and in the best case, even was
tested!). :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-01-12 10:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 13:07 [PATCH 0/5] Allocate memmap from hotadded memory (per device) Oscar Salvador
2020-12-17 13:07 ` [PATCH 1/5] mm: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Oscar Salvador
2021-01-11 16:52 ` David Hildenbrand
2021-01-12 7:26 ` Oscar Salvador
2021-01-12 10:12 ` David Hildenbrand [this message]
2021-01-12 11:17 ` Oscar Salvador
2021-01-12 11:17 ` David Hildenbrand
2020-12-17 13:07 ` [PATCH 2/5] mm,memory_hotplug: Allocate memmap from the added memory range Oscar Salvador
2021-01-18 10:11 ` Oscar Salvador
2021-01-19 13:58 ` David Hildenbrand
2021-01-25 10:39 ` Oscar Salvador
2021-01-25 10:56 ` Oscar Salvador
2021-01-25 11:02 ` David Hildenbrand
2021-01-25 13:36 ` Oscar Salvador
2021-01-25 10:57 ` David Hildenbrand
2021-01-25 11:18 ` Oscar Salvador
2021-01-25 11:23 ` David Hildenbrand
2020-12-17 13:07 ` [PATCH 3/5] acpi,memhotplug: Enable MHP_MEMMAP_ON_MEMORY when supported Oscar Salvador
2021-01-11 16:53 ` David Hildenbrand
2020-12-17 13:07 ` [PATCH 4/5] powerpc/memhotplug: " Oscar Salvador
2021-01-11 16:55 ` David Hildenbrand
2021-01-12 13:31 ` Oscar Salvador
2020-12-17 13:07 ` [PATCH 5/5] mm,memory_hotplug: Add kernel boot option to enable memmap_on_memory Oscar Salvador
2021-01-11 9:05 ` [PATCH 0/5] Allocate memmap from hotadded memory (per device) Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feef406c-105c-138a-b8af-345684876e25@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).