linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: remove unneeded break
Date: Tue, 20 Oct 2020 07:00:37 -0700	[thread overview]
Message-ID: <fef9fb1c-30ee-14fb-a9bd-4f4a554a8bbc@redhat.com> (raw)
In-Reply-To: <CAFLxGvwAVbpUe221N-qS19aFSaJ4hM=J=veHfi+4wAkNTNGAog@mail.gmail.com>


On 10/19/20 1:04 PM, Richard Weinberger wrote:
> On Mon, Oct 19, 2020 at 9:23 PM <trix@redhat.com> wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A break is not needed if it is preceded by a return
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>  drivers/mtd/mtdchar.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
>> index b40f46a43fc6..323035d4f2d0 100644
>> --- a/drivers/mtd/mtdchar.c
>> +++ b/drivers/mtd/mtdchar.c
>> @@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>>                         return -EFAULT;
>>                 return mtd_block_isbad(mtd, offs);
>> -               break;
>>         }
>>
>>         case MEMSETBADBLOCK:
>> @@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>>                         return -EFAULT;
>>                 return mtd_block_markbad(mtd, offs);
>> -               break;
> Acked-by: Richard Weinberger <richard@nod.at>
>
> Do you want to route this patch through mtd or do you carry it?

Not sure if this question is for me.

I do not maintain a subsystem/branch, so through mtd is what i was assuming.

Tom

>


  reply	other threads:[~2020-10-20 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 19:16 [PATCH] mtd: remove unneeded break trix
2020-10-19 20:04 ` Richard Weinberger
2020-10-20 14:00   ` Tom Rix [this message]
2020-10-20 14:20     ` Richard Weinberger
2020-10-28 10:58 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fef9fb1c-30ee-14fb-a9bd-4f4a554a8bbc@redhat.com \
    --to=trix@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard.weinberger@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).