From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>, <linux-kernel@vger.kernel.org>
Cc: <mingo@redhat.com>, <tglx@linutronix.de>, <hpa@zytor.com>,
<x86@kernel.org>, <rostedt@goodmis.org>, <jgross@suse.com>,
<peterz@infradead.org>, <uobergfe@redhat.com>, <joro@8bytes.org>
Subject: Re: [RESEND PATCH 3/3] x86/apic: Clean up the names of legacy irq mode setting related functions
Date: Fri, 19 Jan 2018 14:42:17 +0800 [thread overview]
Message-ID: <ff101d07-2a59-75f1-7e4b-834a8990bc70@cn.fujitsu.com> (raw)
In-Reply-To: <20180105043929.GL7235@x1>
Hi Baoquan,
At 01/05/2018 12:39 PM, Baoquan He wrote:
[...]
> /*
> - * Not an __init, needed by kexec/kdump code.
> - * For safety IO-APIC and Local APIC need be cleared before this.
> + * In legacy irq mode, full DOS compatibility with the uniprocessor PC/AT is
> + * provided by using the APICs in conjunction with standard 8259A-equivalent
> + * programmable interrupt controllers (PICs). It's necessary to deliver legacy
> + * interrupts even when APIC mode is not enabled. This is required by kexec/
> + * kdump before enter into the 2nd kernel.
> */
> void switch_to_legacy_irq_mode(void)
> {
> if (!nr_legacy_irqs())
> return;
>
> - x86_io_apic_ops.disable();
> + ioapic_set_virtual_wire_mode();
> +
> + if (boot_cpu_has(X86_FEATURE_APIC) || apic_from_smp_config())
> + lapic_set_legacy_irq_mode(ioapic_i8259.pin != -1);
Seems these two function, ioapic/lapic_set_legacy_irq_mode should be
exclusive.
But We do that because both the through-lapic and through-ioapic virtual
wire mode need setup the APIC_SPIV_APIC_ENABLED which is only located in
the lapic_set_legacy_irq_mode(). So we need call them both.
IMO, this cleanup may not make it clear. we can separate these two mode
totally or just keep it like before.
Thanks,
dou.
> }
>
> #ifdef CONFIG_X86_32
> diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
> index 1151ccd72ce9..c30f0f273dbd 100644
> --- a/arch/x86/kernel/x86_init.c
> +++ b/arch/x86/kernel/x86_init.c
> @@ -148,5 +148,5 @@ void arch_restore_msi_irqs(struct pci_dev *dev)
>
> struct x86_io_apic_ops x86_io_apic_ops __ro_after_init = {
> .read = native_io_apic_read,
> - .disable = native_disable_io_apic,
> + .disable = switch_to_legacy_irq_mode,
> };
> diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c
> index 49721b4e1975..751472ddf536 100644
> --- a/drivers/iommu/irq_remapping.c
> +++ b/drivers/iommu/irq_remapping.c
> @@ -37,7 +37,7 @@ static void irq_remapping_disable_io_apic(void)
> * now.
> */
> if (boot_cpu_has(X86_FEATURE_APIC) || apic_from_smp_config())
> - disconnect_bsp_APIC(0);
> + lapic_set_legacy_irq_mode(0);
> }
>
> static void __init irq_remapping_modify_x86_ops(void)
>
next prev parent reply other threads:[~2018-01-19 6:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 3:42 [RESEND PATCH 0/3] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-01-05 4:37 ` [RESEND PATCH 1/3] x86/apic: Set up through LAPIC on boot CPU's LINT0 if ioapic is disabled Baoquan He
2018-01-17 9:27 ` Baoquan He
2018-01-05 4:38 ` [RESEND PATCH 2/3] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-01-17 9:30 ` Baoquan He
2018-01-17 9:47 ` Dou Liyang
2018-01-17 10:08 ` Baoquan He
2018-01-19 6:24 ` Dou Liyang
2018-01-05 4:39 ` [RESEND PATCH 3/3] x86/apic: Clean up the names of legacy irq mode setting related functions Baoquan He
2018-01-17 9:31 ` Baoquan He
2018-01-19 6:42 ` Dou Liyang [this message]
2018-01-19 7:21 ` Baoquan He
2018-01-19 8:06 ` Dou Liyang
2018-01-19 9:22 ` Baoquan He
2018-01-25 2:48 ` Baoquan He
2018-01-11 2:05 ` [RESEND PATCH 0/3] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-01-11 18:28 ` Eric W. Biederman
2018-01-17 9:42 ` Baoquan He
2018-01-11 19:05 ` Eric W. Biederman
2018-01-12 6:28 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff101d07-2a59-75f1-7e4b-834a8990bc70@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=uobergfe@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).