From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"Kurt Kanzenbach" <kurt@kmk-computers.de>
Subject: Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node
Date: Tue, 10 Nov 2020 14:40:43 -0800 [thread overview]
Message-ID: <ff118521-6317-b75f-243d-bcd6bbe255d5@gmail.com> (raw)
In-Reply-To: <20201110223709.vca534wynwgfkz77@skbuf>
On 11/10/20 2:37 PM, Vladimir Oltean wrote:
> On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote:
>> Provide a default compatible string which is based on the 58522 SRAB
>> compatible, this allows us to have sane defaults and silences the
>> following warnings:
>>
>> arch/arm/boot/dts/bcm958522er.dt.yaml:
>> ethernet-switch@36000: compatible: 'oneOf' conditional failed,
>> one
>> must be fixed:
>> ['brcm,bcm5301x-srab'] is too short
>> 'brcm,bcm5325' was expected
>> 'brcm,bcm53115' was expected
>> 'brcm,bcm53125' was expected
>> 'brcm,bcm53128' was expected
>> 'brcm,bcm5365' was expected
>> 'brcm,bcm5395' was expected
>> 'brcm,bcm5389' was expected
>> 'brcm,bcm5397' was expected
>> 'brcm,bcm5398' was expected
>> 'brcm,bcm11360-srab' was expected
>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab',
>> 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab',
>> 'brcm,bcm53019-srab']
>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab',
>> 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab',
>> 'brcm,bcm58311-srab', 'brcm,bcm58313-srab']
>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab',
>> 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab',
>> 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab']
>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch',
>> 'brcm,bcm6328-switch', 'brcm,bcm6368-switch']
>> From schema:
>> Documentation/devicetree/bindings/net/dsa/b53.yaml
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
>> index 09fd7e55c069..8453865d1439 100644
>> --- a/arch/arm/boot/dts/bcm-nsp.dtsi
>> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi
>> @@ -386,7 +386,7 @@ ccbtimer1: timer@35000 {
>> };
>>
>> srab: ethernet-switch@36000 {
>> - compatible = "brcm,nsp-srab";
>> + compatible = "brcm,bcm58522-srab", "brcm,nsp-srab";
>> reg = <0x36000 0x1000>,
>> <0x3f308 0x8>,
>> <0x3f410 0xc>;
>> --
>> 2.25.1
>>
>
> I am not getting this.
> The line:
> #include "bcm-nsp.dtsi"
>
> can be found in:
>
> arch/arm/boot/dts/bcm988312hr.dts
> arch/arm/boot/dts/bcm958625hr.dts
> arch/arm/boot/dts/bcm958622hr.dts
> arch/arm/boot/dts/bcm958625k.dts
> arch/arm/boot/dts/bcm958522er.dts
> arch/arm/boot/dts/bcm958525er.dts
> arch/arm/boot/dts/bcm958623hr.dts
> arch/arm/boot/dts/bcm958525xmc.dts
>
>
> The pattern for the other DTS files that include this seems to be to
> overwrite the compatible locally in bcm958522er.dts, like this:
>
> &srab {
> compatible = "brcm,bcm58522-srab", "brcm,nsp-srab";
> };
>
> Is there a reason why you are choosing to put an SoC specific compatible
> in the common bcm-nsp.dtsi?
It is necessary to silence the warnings provided in the commit message
even when the srab node is disabled, since the dt_binding_check rule
will check all of the nodes matching the pattern. If there is a better
way to do this, I would gladly do it differently.
--
Florian
next prev parent reply other threads:[~2020-11-10 22:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 3:31 [PATCH 00/10] Broadcom b53 YAML bindings Florian Fainelli
2020-11-10 3:31 ` [PATCH 01/10] dt-bindings: net: dsa: Extend switch nodes pattern Florian Fainelli
2020-11-10 19:42 ` Vladimir Oltean
2020-11-11 22:24 ` Rob Herring
2020-11-10 3:31 ` [PATCH 02/10] dt-bindings: net: dsa: Document sfp and managed properties Florian Fainelli
2020-11-11 22:33 ` Rob Herring
2020-11-10 3:31 ` [PATCH 03/10] ARM: dts: BCM5301X: Update Ethernet switch node name Florian Fainelli
2020-11-10 19:46 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node Florian Fainelli
2020-11-10 22:06 ` Vladimir Oltean
2020-11-10 22:11 ` Florian Fainelli
2020-11-11 13:06 ` Rafał Miłecki
2020-11-10 3:31 ` [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node Florian Fainelli
2020-11-10 9:31 ` Rafał Miłecki
2020-11-10 15:46 ` Florian Fainelli
2020-11-10 22:12 ` Vladimir Oltean
2020-11-10 22:13 ` Florian Fainelli
2020-11-11 1:48 ` Florian Fainelli
2020-11-11 12:27 ` Rafał Miłecki
2020-11-10 3:31 ` [PATCH 06/10] ARM: dts: NSP: Update ethernet switch node name Florian Fainelli
2020-11-10 22:16 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name Florian Fainelli
2020-11-10 22:27 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node Florian Fainelli
2020-11-10 22:37 ` Vladimir Oltean
2020-11-10 22:40 ` Florian Fainelli [this message]
2020-11-10 22:48 ` Vladimir Oltean
2020-11-10 22:52 ` Florian Fainelli
2020-11-10 23:06 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 09/10] ARM: dts: NSP: Provide defaults ports container node Florian Fainelli
2020-11-10 3:31 ` [PATCH 10/10] dt-bindings: net: dsa: b53: Add YAML bindings Florian Fainelli
2020-11-10 13:21 ` Kurt Kanzenbach
2020-11-10 15:46 ` Florian Fainelli
2020-11-10 22:43 ` Vladimir Oltean
2020-11-11 22:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff118521-6317-b75f-243d-bcd6bbe255d5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=kurt@kmk-computers.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=vivien.didelot@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).