From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B70EC433E6 for ; Wed, 3 Feb 2021 02:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C8B664F6A for ; Wed, 3 Feb 2021 02:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231376AbhBCCYe (ORCPT ); Tue, 2 Feb 2021 21:24:34 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12011 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbhBCCYb (ORCPT ); Tue, 2 Feb 2021 21:24:31 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DVlnf5Y6dzjHhK; Wed, 3 Feb 2021 10:22:30 +0800 (CST) Received: from [10.174.178.147] (10.174.178.147) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Wed, 3 Feb 2021 10:23:48 +0800 Subject: Re: [PATCH v2 5/5] ACPI: thermal: Clean up printing messages To: "Rafael J. Wysocki" , Linux ACPI CC: Linux PM , LKML , "Rafael J. Wysocki" , Zhang Rui , Hans de Goede , Erik Kaneda , "Joe Perches" References: <2367702.B5bJTmGzJm@kreacher> <1991501.dpTHplkurC@kreacher> <2382444.QC0lEobvty@kreacher> From: Hanjun Guo Message-ID: Date: Wed, 3 Feb 2021 10:23:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <2382444.QC0lEobvty@kreacher> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.147] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/3 2:19, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Replace the ACPI_DEBUG_PRINT() instances in thermal.c with > acpi_handle_debug() calls and modify the ACPI_THERMAL_TRIPS_EXCEPTION() > macro in there to use acpi_handle_info() internally, which among other > things causes the excessive log level of the messages printed by it to > be more adequate. > > Drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not > used any more from thermal.c, drop the no longer needed > ACPI_THERMAL_COMPONENT definition from the headers and update the > documentation accordingly. > > While at it, add a pr_fmt() definition to thermal.c, drop the PREFIX > definition from there and replace some pr_warn() calls with pr_info() > or acpi_handle_info() to reduce the excessive log level and (in the > latter case) facilitate easier identification of the message source. > > Signed-off-by: Rafael J. Wysocki > --- > > v1 -> v2: Changelog update Reviewed-by: Hanjun Guo Thanks Hanjun