From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B799CC433EF for ; Thu, 21 Apr 2022 19:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391976AbiDUTe2 (ORCPT ); Thu, 21 Apr 2022 15:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354925AbiDUTeZ (ORCPT ); Thu, 21 Apr 2022 15:34:25 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F355F4D637 for ; Thu, 21 Apr 2022 12:31:34 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id p62so6458174iod.0 for ; Thu, 21 Apr 2022 12:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7HO73uRyd1X43sVJIiW9KkHmXq3f6HmsCw1YIk6coAE=; b=ekMuS1QzTvsonYzLao+l7J0dZQIQsAVZdPTHIQpineOOdoobgztqbHrGOhZoP5gnMG xbM0imCTgCOzDLHsBxp38lXBVmBwac8dHOvMBPSkP3XzbpBEXR/FLgxWg8Axu8NEaw2j NBYfJ0j+vNKusiUfPIbshPoEjqLRbPL8LUlBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7HO73uRyd1X43sVJIiW9KkHmXq3f6HmsCw1YIk6coAE=; b=n2S/yQCRUPoIFTKwFjuj4BxAcbLkw2MOqW5gegzhA/wu61l84LiQHUUH/4e/y6HOSt KUJ2WjVD96CENNg5ZvvefueVP+/oNCHWnFbsqmtsWx9PdRdvuo4hjH8kLLT5+4j3j50A L5UZZ8L5VaUMtpHYI2h1wHyIArD2UJo9/WbywvnhbtxVqIUWSpcKykMmK6NjaQVzMK5I d+wJBYdb5ZU9W+8QvE3jRKzyQLjKkb7bKkEwiXs8T4wby4mUM+IfatzyEaUCaVdDL0Ij 6EwK1GxZYEa6QZMW8OvUE/shiKId45p59pPNw8TVF73La0QBk3xuyUHpjZTzuoHOf037 7HhA== X-Gm-Message-State: AOAM530DyBKHrqAwvJ4zjelTNLxuMOVt3AOTBrDOvzRlbjQNAAhNWI0a lLGsCHc43Wm+wIrSL34lE/wxHA== X-Google-Smtp-Source: ABdhPJyyLsKZJlRbHN11h9x/HycYVP33FRQi2NRbguiHRjuWWF8Ezo+rPVk/UeaQLntzs1ANS+llIg== X-Received: by 2002:a05:6602:27c5:b0:631:a30f:143a with SMTP id l5-20020a05660227c500b00631a30f143amr597205ios.40.1650569494038; Thu, 21 Apr 2022 12:31:34 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id t18-20020a056e02011200b002cbe6ce18e5sm12533395ilm.40.2022.04.21.12.31.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 12:31:33 -0700 (PDT) Subject: Re: [PATCH v2 1/4] selftest/vm: verify mmap addr in mremap_test To: Sidhartha Kumar , shuah@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220420215721.4868-1-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Thu, 21 Apr 2022 13:31:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220420215721.4868-1-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/22 3:57 PM, Sidhartha Kumar wrote: > Avoid calling mmap with requested addresses that are less than the system's > mmap_min_addr. When run as root, mmap returns EACCES when trying to map > addresses < mmap_min_addr. This is not one of the error codes for the > condition to retry the mmap in the test. Rather than arbitrarily retrying > on EACCES, don't attempt an mmap until addr > vm.mmap_min_addr. > > Add a munmap call after an alignment check as the mappings are retained > after the retry and can reach the vm.max_map_count sysctl. > > Signed-off-by: Sidhartha Kumar > --- > v2: > -change comment for description of get_mmap_min_addr() > -fix commit message formatting > Thank you. Reviewed-by: Shuah Khan Andrew, please let me know if you would like me to take this through kselftest tree. thanks, -- Shuah