From: Sinan Kaya <okaya@kernel.org>
To: Shanker Donthineni <sdonthineni@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Vikram Sethi <vsethi@nvidia.com>
Subject: Re: [PATCH 1/1] PCI: Add pci reset quirk for Nvidia GPUs
Date: Fri, 23 Apr 2021 11:12:05 -0400 [thread overview]
Message-ID: <ff4812ba-ec1d-9462-0cbd-029635af3267@kernel.org> (raw)
In-Reply-To: <20210423145402.14559-1-sdonthineni@nvidia.com>
+Alex,
On 4/23/2021 10:54 AM, Shanker Donthineni wrote:
> +static int reset_nvidia_gpu_quirk(struct pci_dev *dev, int probe)
> +{
> +#ifdef CONFIG_ACPI
> + acpi_handle handle = ACPI_HANDLE(&dev->dev);
> +
> + /*
> + * Check for the affected devices' ID range. If device is not in
> + * the affected range, return -ENOTTY indicating no device
> + * specific reset method is available.
> + */
> + if ((dev->device & 0xffc0) != 0x2340)
> + return -ENOTTY;
> +
> + /*
> + * Return -ENOTTY indicating no device-specific reset method if _RST
> + * method is not defined
> + */
> + if (!handle || !acpi_has_method(handle, "_RST"))
> + return -ENOTTY;
> +
> + /* Return 0 for probe phase indicating that we can reset this device */
> + if (probe)
> + return 0;
> +
> + /* Invoke _RST() method to perform the device-specific reset */
> + if (ACPI_FAILURE(acpi_evaluate_object(handle, "_RST", NULL, NULL))) {
> + pci_warn(dev, "Failed to reset the device\n");
> + return -EINVAL;
> + }
> + return 0;
> +#else
> + return -ENOTTY;
> +#endif
> +}
Interesting, some pieces of this function (especially the ACPI _RST)
could be generalized.
next prev parent reply other threads:[~2021-04-23 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 14:54 [PATCH 1/1] PCI: Add pci reset quirk for Nvidia GPUs Shanker Donthineni
2021-04-23 15:12 ` Sinan Kaya [this message]
2021-04-23 15:37 ` Alex Williamson
2021-04-23 21:45 ` Shanker R Donthineni
2021-04-26 18:19 ` Christoph Hellwig
2021-04-26 19:15 ` Alex Williamson
2021-04-26 19:02 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4812ba-ec1d-9462-0cbd-029635af3267@kernel.org \
--to=okaya@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).