From: Kimberly Brown <kimbrownkd@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/8] samples/kobject: Replace foo_ktype's default_attrs field with groups
Date: Mon, 1 Apr 2019 22:51:24 -0400 [thread overview]
Message-ID: <ff51525109ba2697b0e0f91b622c1473ee2d0141.1554151487.git.kimbrownkd@gmail.com> (raw)
In-Reply-To: <cover.1554151487.git.kimbrownkd@gmail.com>
The kobj_type default_attrs field is being replaced by the
default_groups field. Replace foo_ktype's default_attrs field with
default_groups and use the ATTRIBUTE_GROUPS macro to create
foo_default_groups.
This patch was tested by loading the kset-example module and verifying
that the sysfs files for the attributes in the default group were
created.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
---
samples/kobject/kset-example.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c
index 401328fd687d..c8010f126808 100644
--- a/samples/kobject/kset-example.c
+++ b/samples/kobject/kset-example.c
@@ -178,6 +178,7 @@ static struct attribute *foo_default_attrs[] = {
&bar_attribute.attr,
NULL, /* need to NULL terminate the list of attributes */
};
+ATTRIBUTE_GROUPS(foo_default);
/*
* Our own ktype for our kobjects. Here we specify our sysfs ops, the
@@ -187,7 +188,7 @@ static struct attribute *foo_default_attrs[] = {
static struct kobj_type foo_ktype = {
.sysfs_ops = &foo_sysfs_ops,
.release = foo_release,
- .default_attrs = foo_default_attrs,
+ .default_groups = foo_default_groups,
};
static struct kset *example_kset;
--
2.17.1
next prev parent reply other threads:[~2019-04-02 2:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 20:14 [PATCH] kobject: Add support for default attribute groups to kobj_type Kimberly Brown
2019-03-23 6:07 ` Greg Kroah-Hartman
2019-03-24 3:48 ` Kimberly Brown
2019-03-24 5:15 ` Greg Kroah-Hartman
2019-04-02 2:51 ` [PATCH v2 0/8] kobject: Add default group support to kobj_type and replace subsystem uses Kimberly Brown
2019-04-02 2:51 ` [PATCH v2 1/8] kobject: Add support for default attribute groups to kobj_type Kimberly Brown
2019-04-02 2:51 ` Kimberly Brown [this message]
2019-04-02 2:51 ` [PATCH v2 3/8] block: Replace all ktype default_attrs with groups Kimberly Brown
2019-04-02 16:02 ` Bart Van Assche
2019-04-02 17:46 ` Greg Kroah-Hartman
2019-04-02 18:06 ` Bart Van Assche
2019-04-02 2:51 ` [PATCH v2 4/8] net-sysfs: Replace ktype default_attrs field " Kimberly Brown
2019-04-02 2:51 ` [PATCH v2 5/8] irqdesc: Replace irq_kobj_type's " Kimberly Brown
2019-04-02 8:04 ` Thomas Gleixner
2019-04-02 2:51 ` [PATCH v2 6/8] padata: Replace padata_attr_type " Kimberly Brown
2019-04-02 2:51 ` [PATCH v2 7/8] cpufreq: schedutil: Replace " Kimberly Brown
2019-04-02 7:56 ` Rafael J. Wysocki
2019-04-02 8:50 ` Peter Zijlstra
2019-04-02 2:51 ` [PATCH v2 8/8] livepatch: Replace klp_ktype_patch's default_attrs " Kimberly Brown
2019-04-02 10:22 ` Jiri Kosina
2019-04-03 11:51 ` Miroslav Benes
2019-04-08 14:16 ` Petr Mladek
2019-04-02 6:29 ` [PATCH v2 0/8] kobject: Add default group support to kobj_type and replace subsystem uses Greg Kroah-Hartman
2019-04-25 20:12 ` Greg Kroah-Hartman
2019-04-27 6:18 ` Kimberly Brown
2019-04-27 6:41 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff51525109ba2697b0e0f91b622c1473ee2d0141.1554151487.git.kimbrownkd@gmail.com \
--to=kimbrownkd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).