From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5C5C43603 for ; Fri, 20 Dec 2019 02:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63A35206CB for ; Fri, 20 Dec 2019 02:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727148AbfLTCHj (ORCPT ); Thu, 19 Dec 2019 21:07:39 -0500 Received: from smtprelay0157.hostedemail.com ([216.40.44.157]:50013 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726964AbfLTCHj (ORCPT ); Thu, 19 Dec 2019 21:07:39 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 94152837F24D; Fri, 20 Dec 2019 02:07:37 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bag50_5f8a9fc957d61 X-Filterd-Recvd-Size: 1672 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Fri, 20 Dec 2019 02:07:36 +0000 (UTC) Message-ID: Subject: Re: [PATCH] net/mlx5e: Fix printk format warning From: Joe Perches To: Olof Johansson , Saeed Mahameed , Leon Romanovsky Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 19 Dec 2019 18:06:57 -0800 In-Reply-To: <20191220001517.105297-1-olof@lixom.net> References: <20191220001517.105297-1-olof@lixom.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote: > Use "%zu" for size_t. Seen on ARM allmodconfig: [] > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c b/drivers/net/ethernet/mellanox/mlx5/core/wq.c [] > @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct mlx5_wq_cyc *wq, u16 ix, u8 nstrides) > len = nstrides << wq->fbc.log_stride; > wqe = mlx5_wq_cyc_get_wqe(wq, ix); > > - pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n", > + pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %zu\n", > mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len); > print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, 16, 1, wqe, len, false); > } One might expect these 2 outputs to be at the same KERN_ too. One is KERN_INFO the other KERN_WARNING