* [PATCH] staging: rtl8188eu: Line over 100 characters
@ 2021-07-22 16:41 Jignesh Patel
2021-07-22 16:46 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jignesh Patel @ 2021-07-22 16:41 UTC (permalink / raw)
Cc: jigs0101, Larry Finger, Greg Kroah-Hartman, Guenter Roeck,
Martin Kaiser, Dan Carpenter, Ivan Safonov, Paul McQuade,
Phillip Potter, linux-staging, linux-kernel
Break various lines into multiple lines to respect 100 character width limit.
Reported by checkpatch.pl
Signed-off-by: Jignesh Patel <jigs0101@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index b817aa8b9de4..b83d6da01b7c 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
updated = ap_free_sta(padapter, psta, true,
WLAN_REASON_DEAUTH_LEAVING);
} else {
- /* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
+ /** TODO: Aging mechanism to digest frames in
+ * sleep_q to avoid running out of xmitframe
+ */
if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
- padapter->xmitpriv.free_xmitframe_cnt < (NR_XMITFRAME / pstapriv->asoc_list_cnt / 2))
+ padapter->xmitpriv.free_xmitframe_cnt <
+ (NR_XMITFRAME / pstapriv->asoc_list_cnt / 2))
wakeup_sta_to_xmit(padapter, psta);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8188eu: Line over 100 characters
2021-07-22 16:41 [PATCH] staging: rtl8188eu: Line over 100 characters Jignesh Patel
@ 2021-07-22 16:46 ` Greg Kroah-Hartman
2021-07-22 16:59 ` Joe Perches
2021-07-23 7:08 ` Jignesh Patel
2 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-07-22 16:46 UTC (permalink / raw)
To: Jignesh Patel
Cc: Larry Finger, Guenter Roeck, Martin Kaiser, Dan Carpenter,
Ivan Safonov, Paul McQuade, Phillip Potter, linux-staging,
linux-kernel
On Thu, Jul 22, 2021 at 10:11:37PM +0530, Jignesh Patel wrote:
> Break various lines into multiple lines to respect 100 character width limit.
> Reported by checkpatch.pl
>
> Signed-off-by: Jignesh Patel <jigs0101@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index b817aa8b9de4..b83d6da01b7c 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
> updated = ap_free_sta(padapter, psta, true,
> WLAN_REASON_DEAUTH_LEAVING);
> } else {
> - /* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
> + /** TODO: Aging mechanism to digest frames in
Does this line look correct now?
Please look at how comments are formatted...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8188eu: Line over 100 characters
2021-07-22 16:41 [PATCH] staging: rtl8188eu: Line over 100 characters Jignesh Patel
2021-07-22 16:46 ` Greg Kroah-Hartman
@ 2021-07-22 16:59 ` Joe Perches
2021-07-23 7:08 ` Jignesh Patel
2 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2021-07-22 16:59 UTC (permalink / raw)
To: Jignesh Patel
Cc: Larry Finger, Greg Kroah-Hartman, Guenter Roeck, Martin Kaiser,
Dan Carpenter, Ivan Safonov, Paul McQuade, Phillip Potter,
linux-staging, linux-kernel
On Thu, 2021-07-22 at 22:11 +0530, Jignesh Patel wrote:
> Break various lines into multiple lines to respect 100 character width limit.
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
[]
> @@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
> updated = ap_free_sta(padapter, psta, true,
> WLAN_REASON_DEAUTH_LEAVING);
> } else {
> - /* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
> + /** TODO: Aging mechanism to digest frames in
Please do not use double asterisks to start a comment.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: staging: rtl8188eu: Line over 100 characters
2021-07-22 16:41 [PATCH] staging: rtl8188eu: Line over 100 characters Jignesh Patel
2021-07-22 16:46 ` Greg Kroah-Hartman
2021-07-22 16:59 ` Joe Perches
@ 2021-07-23 7:08 ` Jignesh Patel
2 siblings, 0 replies; 5+ messages in thread
From: Jignesh Patel @ 2021-07-23 7:08 UTC (permalink / raw)
Cc: jigs0101, Larry Finger, Greg Kroah-Hartman, Guenter Roeck,
Martin Kaiser, Ivan Safonov, Dan Carpenter, Paul McQuade,
Phillip Potter, linux-staging, linux-kernel
Dear Greg K-H, Joe Perches,
Thank you for your comments and drawn my attention.
I will modify and submit the patch again.
Regards,
Jignesh.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: rtl8188eu: Line over 100 characters
@ 2021-07-23 9:45 Jignesh Patel
0 siblings, 0 replies; 5+ messages in thread
From: Jignesh Patel @ 2021-07-23 9:45 UTC (permalink / raw)
Cc: jigs0101, Larry Finger, Greg Kroah-Hartman, Guenter Roeck,
Martin Kaiser, Dan Carpenter, Ivan Safonov, Paul McQuade,
Phillip Potter, linux-staging, linux-kernel
Break lines into multiple lines to respect 100 character width limit.
Reported by checkpatch.pl
Signed-off-by: Jignesh Patel <jigs0101@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index b817aa8b9de4..a6e756720214 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
updated = ap_free_sta(padapter, psta, true,
WLAN_REASON_DEAUTH_LEAVING);
} else {
- /* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
+ /* TODO: Aging mechanism to digest frames in
+ * sleep_q to avoid running out of xmitframe
+ */
if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
- padapter->xmitpriv.free_xmitframe_cnt < (NR_XMITFRAME / pstapriv->asoc_list_cnt / 2))
+ padapter->xmitpriv.free_xmitframe_cnt <
+ (NR_XMITFRAME / pstapriv->asoc_list_cnt / 2))
wakeup_sta_to_xmit(padapter, psta);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-23 9:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 16:41 [PATCH] staging: rtl8188eu: Line over 100 characters Jignesh Patel
2021-07-22 16:46 ` Greg Kroah-Hartman
2021-07-22 16:59 ` Joe Perches
2021-07-23 7:08 ` Jignesh Patel
2021-07-23 9:45 [PATCH] " Jignesh Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).