From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Allan Nielsen <Allan.Nielsen@microsemi.com>,
razvan.stefanescu@nxp.com, po.liu@nxp.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH net-next v3 2/7] net: phy: mscc-miim: Add MDIO driver
Date: Mon, 14 May 2018 13:52:01 -0700 [thread overview]
Message-ID: <ffa13558-8ca0-00e5-9603-db8ee25a483e@gmail.com> (raw)
In-Reply-To: <20180514200500.2953-3-alexandre.belloni@bootlin.com>
On 05/14/2018 01:04 PM, Alexandre Belloni wrote:
> Add a driver for the Microsemi MII Management controller (MIIM) found on
> Microsemi SoCs.
> On Ocelot, there are two controllers, one is connected to the internal
> PHYs, the other one can communicate with external PHYs.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Nothing critical, so:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
[snip]
> +static int mscc_miim_reset(struct mii_bus *bus)
> +{
> + struct mscc_miim_dev *miim = bus->priv;
> +
> + if (miim->phy_regs) {
> + writel(0, miim->phy_regs + MSCC_PHY_REG_PHY_CFG);
> + writel(0x1ff, miim->phy_regs + MSCC_PHY_REG_PHY_CFG);
> + mdelay(500);
Can this become an msleep() in the future?
> + }
> +
> + return 0;
> +}
> +
> +static int mscc_miim_probe(struct platform_device *pdev)
> +{
> + struct resource *res;
> + struct mii_bus *bus;
> + struct mscc_miim_dev *dev;
> + int ret;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res)
> + return -ENODEV;
> +
> + bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
> + if (!bus)
> + return -ENOMEM;
> +
> + bus->name = "mscc_miim";
> + bus->read = mscc_miim_read;
> + bus->write = mscc_miim_write;
> + bus->reset = mscc_miim_reset;
> + snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev));
> + bus->parent = &pdev->dev;
> +
> + dev = bus->priv;
> + dev->regs = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(dev->regs)) {
> + dev_err(&pdev->dev, "Unable to map MIIM registers\n");
> + return PTR_ERR(dev->regs);
> + }
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> + if (res) {
> + dev->phy_regs = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(dev->phy_regs)) {
> + dev_err(&pdev->dev, "Unable to map internal phy registers\n");
> + return PTR_ERR(dev->phy_regs);
> + }
> + }
> +
> + if (pdev->dev.of_node)
> + ret = of_mdiobus_register(bus, pdev->dev.of_node);
> + else
> + ret = mdiobus_register(bus);
There are other drivers doing that, we should probably make that the
standard behavior of of_mdiobus_register(), like before, candidate for
another patch.
--
Florian
next prev parent reply other threads:[~2018-05-14 20:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 20:04 [PATCH net-next v3 0/7] Microsemi Ocelot Ethernet switch support Alexandre Belloni
2018-05-14 20:04 ` [PATCH net-next v3 1/7] dt-bindings: net: add DT bindings for Microsemi MIIM Alexandre Belloni
2018-05-14 20:47 ` Andrew Lunn
2018-05-14 20:04 ` [PATCH net-next v3 2/7] net: phy: mscc-miim: Add MDIO driver Alexandre Belloni
2018-05-14 20:52 ` Florian Fainelli [this message]
2018-05-14 20:04 ` [PATCH net-next v3 3/7] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch Alexandre Belloni
2018-05-14 20:49 ` Andrew Lunn
2018-05-14 20:53 ` Florian Fainelli
2018-05-14 20:04 ` [PATCH net-next v3 4/7] net: mscc: Add initial Ocelot switch support Alexandre Belloni
2018-05-14 20:56 ` Andrew Lunn
2018-05-14 20:04 ` [PATCH net-next v3 5/7] MIPS: mscc: Add switch to ocelot Alexandre Belloni
2018-05-14 20:49 ` Andrew Lunn
2018-05-14 20:54 ` Florian Fainelli
2018-05-14 20:04 ` [PATCH net-next v3 6/7] MIPS: mscc: connect phys to ports on ocelot_pcb123 Alexandre Belloni
2018-05-14 20:50 ` Andrew Lunn
2018-05-14 20:54 ` Florian Fainelli
2018-05-14 20:05 ` [PATCH net-next v3 7/7] MAINTAINERS: Add entry for Microsemi Ethernet switches Alexandre Belloni
2018-05-14 20:51 ` Andrew Lunn
2018-05-14 20:58 ` [PATCH net-next v3 0/7] Microsemi Ocelot Ethernet switch support Andrew Lunn
2018-05-14 21:47 ` James Hogan
2018-05-16 11:26 ` Alexandre Belloni
2018-05-15 20:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffa13558-8ca0-00e5-9603-db8ee25a483e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Allan.Nielsen@microsemi.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=razvan.stefanescu@nxp.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).