From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: llcc: Add llcc device availability check
Date: Tue, 12 Mar 2024 21:55:08 +0530 [thread overview]
Message-ID: <ffa32cab-fa74-0c37-b3c9-c3c41cff9f9c@quicinc.com> (raw)
In-Reply-To: <20332b6f-e0cc-4356-83ec-0c9771481083@kernel.org>
On 3/7/2024 3:51 PM, Krzysztof Kozlowski wrote:
> On 20/02/2024 13:28, Mukesh Ojha wrote:
>> When llcc driver is enabled and llcc device is not
>> physically there on the SoC, client can get
>> -EPROBE_DEFER on calling llcc_slice_getd() and it
>> is possible they defer forever.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Noted.
>
>>
>> Let's add a check device availabilty and set the
>> appropriate applicable error in drv_data.
>>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>> ---
>> drivers/soc/qcom/llcc-qcom.c | 23 ++++++++++++++++++++++-
>> 1 file changed, 22 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
>> index 4ca88eaebf06..cb336b183bba 100644
>> --- a/drivers/soc/qcom/llcc-qcom.c
>> +++ b/drivers/soc/qcom/llcc-qcom.c
>> @@ -769,6 +769,27 @@ static const struct qcom_sct_config x1e80100_cfgs = {
>> };
>>
>> static struct llcc_drv_data *drv_data = (void *) -EPROBE_DEFER;
>> +static DEFINE_MUTEX(dev_avail);
>> +
>> +static bool is_llcc_device_available(void)
>> +{
>> + static struct llcc_drv_data *ptr;
>> +
>> + mutex_lock(&dev_avail);
>> + if (!ptr) {
>> + struct device_node *node;
>> +
>> + node = of_find_node_by_name(NULL, "system-cache-controller");
>
> Why do you look names by name? This create undocumented ABI. >
> NAK (also for any future uses of such of_find_node_by_name()).
I agree, what if we add a common compatible string like qcom,llcc to all
llcc supported SoCs.
-Mukesh
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-03-12 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 12:28 [PATCH] soc: qcom: llcc: Add llcc device availability check Mukesh Ojha
2024-02-22 18:07 ` Sahil Chandna
2024-02-26 10:32 ` Mukesh Ojha
2024-02-26 10:49 ` Sahil Chandna
2024-02-26 11:00 ` Mukesh Ojha
2024-03-07 10:21 ` Krzysztof Kozlowski
2024-03-12 16:25 ` Mukesh Ojha [this message]
2024-03-12 16:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffa32cab-fa74-0c37-b3c9-c3c41cff9f9c@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).