From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4465FC433EF for ; Fri, 8 Jul 2022 19:42:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239291AbiGHTmt (ORCPT ); Fri, 8 Jul 2022 15:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239162AbiGHTmp (ORCPT ); Fri, 8 Jul 2022 15:42:45 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D175D84EF9 for ; Fri, 8 Jul 2022 12:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657309364; x=1688845364; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=cvvPOf0ESif5qtfECCusv626UD+VI6e+YqhLOB1P/oY=; b=hFPh6gyZQjewkfV/hszb7vVMr8O2dY3t2UDCKAhwzOE65kf69phv4Bsm kSgvBK1G/vVTaSHZov6aX45Any2NH1yMOjbCxkfvH0is5iNUHc7n3v6gJ 1Bo0UrC2oW536CdCA6GlTyZZZx8k1fwbYTCW0/kPaInkswgNgwJeiSN9o Q=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 08 Jul 2022 12:42:44 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 12:42:44 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 8 Jul 2022 12:42:43 -0700 Received: from [10.111.160.191] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 8 Jul 2022 12:42:41 -0700 Message-ID: Date: Fri, 8 Jul 2022 12:42:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] drm/msm/dsi: Set panel orientation when directly connected Content-Language: en-US From: Abhinav Kumar To: Doug Anderson , Stephen Boyd CC: Rob Clark , Dmitry Baryshkov , LKML , , Sean Paul , dri-devel , freedreno , Hsin-Yi Wang References: <20220706191442.1150634-1-swboyd@chromium.org> <60252405-81f2-2465-bc20-5f91a9072031@quicinc.com> In-Reply-To: <60252405-81f2-2465-bc20-5f91a9072031@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/8/2022 9:00 AM, Abhinav Kumar wrote: > > > On 7/8/2022 8:25 AM, Doug Anderson wrote: >> Hi, >> >> On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote: >>> >>> Set the panel orientation in drm when the panel is directly connected, >>> i.e. we're not using an external bridge. The external bridge case is >>> already handled by the panel bridge code, so we only update the path we >>> take when the panel is directly connected/internal. This silences a >>> warning splat coming from __drm_mode_object_add() on Wormdingler boards. >>> >>> Cc: Hsin-Yi Wang >>> Cc: Douglas Anderson >>> Signed-off-by: Stephen Boyd >>> --- >>> >>> This relies on commit 5e41b01a7808 ("drm/panel: Add an API to allow drm >>> to set orientation from panel") which is in drm-misc >>> >>>   drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 ++ >>>   1 file changed, 2 insertions(+) >> >> I don't personally have objections to this, but (to my understanding) >> "the future" is that everyone should use panel_bridge. If we made the >> move to panel_bridge today then we wouldn't need to do this. In >> general I think panel_bridge would end up letting us delete a bunch of >> code... >> >> See commit 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with >> panel-bridge") for when this was done by ti-sn65dsi86. >> >> Then again, I spent a small amount of time looking into this and it's >> definitely non-trivial. Still likely worthwhile, but not worth >> blocking a tiny fix like this. It also should be fairly obvious that >> we should delete this when we switch to panel_bridge. > > Right, from what I saw on IRC, panel_bridge is the way forward and > dmitry did push a change to do that > > https://patchwork.freedesktop.org/patch/492585/ > > But I think we can go ahead with this change because its simple enough. > > Regarding the panel_bridge migration, I am going to start reviewing that > as well. > I did some more digging up on the panel_bridge migration. Dmitry has posted this towards december last year https://patches.linaro.org/project/dri-devel/patch/20211207222901.988484-3-dmitry.baryshkov@linaro.org/ and I had given my R-b on this already in Jan. I am not sure why this change was dropped OR was not part of msm-next already. Dmitry, any reason this change was left out so long and why the R-b was not retained and this was reposted? From what i can see the change looks identical. Thanks Abhinav >> >> Thus: >> >> Reviewed-by: Douglas Anderson >> >> I'll assume that we'll just snooze this commit until drm-misc-next >> merges into a tree that msm-next is based on, which will probably be >> the next -rc1. If desired and Acked I could land this in >> drm-misc-next, but it's probably not worth it?