From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4826EC433F5 for ; Thu, 9 Dec 2021 15:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236209AbhLIPZR (ORCPT ); Thu, 9 Dec 2021 10:25:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:51466 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235923AbhLIPZQ (ORCPT ); Thu, 9 Dec 2021 10:25:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639063302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6YIGwGqD4dGu6FG9WPJtv2xc8Ws3EOTfiVlMjVaJjDc=; b=e4zSpZRskvKrWZrUUWzwgkjPXSaQ2I5Fu4EUXbwTnHYaMvrM0gIHVJZ1D7yJiS/7kBCcNW 1tUyLu/czt0Z6Rwh7+N3FxasBwtChluyTV9qqmXlG0veMQT+JQ7c6tpARmRaFwGv5uSTIg yCH6VRH34bbeCr0Ip3mQtSRFRoRIzGE= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-zMwevSHGMUexi0qSJNawsw-1; Thu, 09 Dec 2021 10:21:41 -0500 X-MC-Unique: zMwevSHGMUexi0qSJNawsw-1 Received: by mail-ed1-f69.google.com with SMTP id k7-20020aa7c387000000b003e7ed87fb31so5608174edq.3 for ; Thu, 09 Dec 2021 07:21:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6YIGwGqD4dGu6FG9WPJtv2xc8Ws3EOTfiVlMjVaJjDc=; b=xNGxfPTQ6z/fJc23VOj/cusGAPI2y9LzwwwiSnO1Tdis2hcC/xMGx2CVescDxr/l1s Fbh4cWpRVyR0HkoK/XEWRJHHTqst49U3XM9Z2Xbp6Bz0M6nVyCb4dYGb5ociuGU4neGE cTUB1pI1JL7jnUTbUc+pxaE5pieY1uM5TAukF2WfV+annht5CQCStcnUPy35XgG/9mr0 u3cFP2as3N9yhmU9gG2FuIpA2Fu3fzaFZvHOlmEEl/EKgOoJlbp4qPFsbVtBAOzO639A 7FU+3FttKsin5lO8e7ZZevEjOj2LxmqTi4GH1SygvQimoultnhjR7wAwuBWPjkWNwiIf dqpQ== X-Gm-Message-State: AOAM532EVbLeNYHhKZOLqIxlpRG1BA33ZS48iRb6YOT0zKed2KUNQd+f in5LJk5r5A1qU+QeepUvHwiHPMuW1ccHyy73lT5/L4+mYOOewDdsxZR27b0SDbpJOGOq9kH5G17 HY54tbJkcV1b32m4SBhWLYTyJ X-Received: by 2002:a17:907:3fa0:: with SMTP id hr32mr16327581ejc.443.1639063300419; Thu, 09 Dec 2021 07:21:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyF1/alZruXsxPvxvH8kFaKeZWv95VPojWHHwg+QJ4I8m8OmUqA7eco9d+KB2Cp/F+WGLjJAQ== X-Received: by 2002:a17:907:3fa0:: with SMTP id hr32mr16327550ejc.443.1639063300133; Thu, 09 Dec 2021 07:21:40 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id e26sm50021edr.82.2021.12.09.07.21.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 07:21:39 -0800 (PST) Message-ID: Date: Thu, 9 Dec 2021 16:21:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Content-Language: en-US To: Andy Shevchenko , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jens Axboe , Damien Le Moal References: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12/9/21 15:59, Andy Shevchenko wrote: > platform_get_irq() will print a message when it fails. > No need to repeat this. > > While at it, drop redundant check for 0 as platform_get_irq() spills > out a big WARN() in such case. > > Signed-off-by: Andy Shevchenko Thanks, the series looks good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans > --- > drivers/ata/libahci_platform.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c > index 0910441321f7..1af642c84e7b 100644 > --- a/drivers/ata/libahci_platform.c > +++ b/drivers/ata/libahci_platform.c > @@ -579,13 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev, > int i, irq, n_ports, rc; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(dev, "no irq\n"); > + if (irq < 0) > return irq; > - } > - if (!irq) > - return -EINVAL; > > hpriv->irq = irq; > >