linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	apw@canonical.com, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions
Date: Tue, 07 Apr 2020 12:03:52 -0700	[thread overview]
Message-ID: <ffdaa916088c95a984b2953334ea446251b2ecd9.camel@perches.com> (raw)
In-Reply-To: <20200407190029.892-1-christophe.jaillet@wanadoo.fr>

On Tue, 2020-04-07 at 21:00 +0200, Christophe JAILLET wrote:
> Here, we look for function such as 'netdev_alloc_skb_ip_align', so a '_'
> is missing in the regex.
> 
> To make sure:
>    grep -r --include=*.c skbip_a * | wc   ==>   0 results
>    grep -r --include=*.c skb_ip_a * | wc  ==> 112 results

Acked-by: Joe Perches <joe@perches.com>

> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 529c892722b9..c392ab8ea12e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -479,7 +479,7 @@ our $allocFunctions = qr{(?x:
>  		(?:kv|k|v)[czm]alloc(?:_node|_array)? |
>  		kstrdup(?:_const)? |
>  		kmemdup(?:_nul)?) |
> -	(?:\w+)?alloc_skb(?:ip_align)? |
> +	(?:\w+)?alloc_skb(?:_ip_align)? |
>  				# dev_alloc_skb/netdev_alloc_skb, et al
>  	dma_alloc_coherent
>  )};


      reply	other threads:[~2020-04-07 19:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 19:00 [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions Christophe JAILLET
2020-04-07 19:03 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffdaa916088c95a984b2953334ea446251b2ecd9.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).