From: Pratyush Anand <panand@redhat.com>
To: Pavel Labath <labath@google.com>, Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Jan Kratochvil <jan.kratochvil@redhat.com>,
onestero@redhat.com, Pavel Labath <test.tberghammer@gmail.com>
Subject: Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint addresses
Date: Wed, 9 Nov 2016 23:09:10 +0530 [thread overview]
Message-ID: <ffe812c9-0f2d-c791-8c93-2ad71849042e@redhat.com> (raw)
In-Reply-To: <CAJt8pk9tH5nm5sUsKx-dAvW4uzKP+EoRumhYV1mXsU_mk6dRDg@mail.gmail.com>
On Tuesday 08 November 2016 05:28 PM, Pavel Labath wrote:
>>> + if (min_dist > 0 && min_dist != -1) {
>>> >> + /* No exact match found. */
>>> >> + wp = slots[closest_match];
>>> >> + info = counter_arch_bp(wp);
>>> >> + info->trigger = addr;
>>> >> + perf_bp_event(wp, regs);
>>> >> + }
>> >
>> > Why don't we need to bother with the stepping in the case of a non-exact
>> > match?
> Good catch. I think we do. I must have dropped that part somehow.
>
> Pratyush, could you include the attached fixup in the next batch?
Ok, will do.
~Pratyush
next prev parent reply other threads:[~2016-11-09 17:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 5:48 [PATCH V2 0/5] ARM64: More flexible HW watchpoint Pratyush Anand
2016-10-20 5:48 ` [PATCH V2 1/5] hw_breakpoint: Allow watchpoint of length 3,5,6 and 7 Pratyush Anand
2016-10-20 5:48 ` [PATCH V2 2/5] arm64: Allow hw watchpoint at varied offset from base address Pratyush Anand
2016-11-08 3:26 ` Will Deacon
2016-11-09 17:38 ` Pratyush Anand
2016-10-20 5:48 ` [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint addresses Pratyush Anand
2016-11-08 3:29 ` Will Deacon
2016-11-08 11:58 ` Pavel Labath
2016-11-09 17:39 ` Pratyush Anand [this message]
2016-10-20 5:48 ` [PATCH V2 4/5] arm64: Allow hw watchpoint of length 3,5,6 and 7 Pratyush Anand
2016-10-20 5:48 ` [PATCH V2 5/5] selftests: arm64: add test for unaligned/inexact watchpoint handling Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffe812c9-0f2d-c791-8c93-2ad71849042e@redhat.com \
--to=panand@redhat.com \
--cc=jan.kratochvil@redhat.com \
--cc=labath@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=onestero@redhat.com \
--cc=test.tberghammer@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).