From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Vikash Garodia <vgarodia@codeaurora.org>,
hverkuil@xs4all.nl, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, acourbot@chromium.org
Subject: Re: [PATCH v11 1/5] venus: firmware: add routine to reset ARM9
Date: Wed, 17 Oct 2018 11:49:39 +0300 [thread overview]
Message-ID: <fffd5b1f-73b5-81d5-a95b-a2dc9db1961d@linaro.org> (raw)
In-Reply-To: <1539005572-803-2-git-send-email-vgarodia@codeaurora.org>
Hi Vikash,
On 10/08/2018 04:32 PM, Vikash Garodia wrote:
> Add routine to reset the ARM9 and brings it out of reset. Also
> abstract the Venus CPU state handling with a new function. This
> is in preparation to add PIL functionality in venus driver.
>
> Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org>
> ---
> drivers/media/platform/qcom/venus/core.h | 2 ++
> drivers/media/platform/qcom/venus/firmware.c | 33 ++++++++++++++++++++++++
> drivers/media/platform/qcom/venus/firmware.h | 11 ++++++++
> drivers/media/platform/qcom/venus/hfi_venus.c | 13 +++-------
> drivers/media/platform/qcom/venus/hfi_venus_io.h | 7 +++++
> 5 files changed, 57 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
> index 2f02365..385e309 100644
> --- a/drivers/media/platform/qcom/venus/core.h
> +++ b/drivers/media/platform/qcom/venus/core.h
> @@ -98,6 +98,7 @@ struct venus_caps {
> * @dev: convenience struct device pointer
> * @dev_dec: convenience struct device pointer for decoder device
> * @dev_enc: convenience struct device pointer for encoder device
> + * @use_tz: a flag that suggests presence of trustzone
> * @lock: a lock for this strucure
> * @instances: a list_head of all instances
> * @insts_count: num of instances
> @@ -129,6 +130,7 @@ struct venus_core {
> struct device *dev;
> struct device *dev_dec;
> struct device *dev_enc;
> + bool use_tz;
could you make it unsigned? For more info please run checkpatch --strict.
I know that we have structure members of type bool already - that should
be fixed with follow-up patches, I guess.
--
regards,
Stan
next prev parent reply other threads:[~2018-10-17 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 13:32 [PATCH v11 0/5] Venus updates - PIL Vikash Garodia
2018-10-08 13:32 ` [PATCH v11 1/5] venus: firmware: add routine to reset ARM9 Vikash Garodia
2018-10-17 8:49 ` Stanimir Varbanov [this message]
2018-10-18 1:42 ` Joe Perches
2018-10-18 8:41 ` Stanimir Varbanov
2018-10-08 13:32 ` [PATCH v11 2/5] venus: firmware: move load firmware in a separate function Vikash Garodia
2018-10-08 13:32 ` [PATCH v11 3/5] venus: firmware: register separate platform_device for firmware loader Vikash Garodia
2018-10-08 13:32 ` [PATCH v11 4/5] venus: firmware: add no TZ boot and shutdown routine Vikash Garodia
2018-10-08 13:32 ` [PATCH v11 5/5] dt-bindings: media: Document bindings for venus firmware device Vikash Garodia
2018-10-16 15:55 ` [PATCH v11 0/5] Venus updates - PIL Vikash Garodia
2018-10-17 7:07 ` Stanimir Varbanov
2018-10-17 9:10 ` Stanimir Varbanov
2018-10-17 13:21 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffd5b1f-73b5-81d5-a95b-a2dc9db1961d@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=acourbot@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).