From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0279C433E7 for ; Wed, 14 Oct 2020 19:59:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8F5D206DC for ; Wed, 14 Oct 2020 19:59:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gouders.net header.i=@gouders.net header.b="q90nZmaX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728721AbgJNT7O (ORCPT ); Wed, 14 Oct 2020 15:59:14 -0400 Received: from services.gouders.net ([141.101.32.176]:33458 "EHLO services.gouders.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgJNT7O (ORCPT ); Wed, 14 Oct 2020 15:59:14 -0400 Received: from localhost (ltea-047-066-024-155.pools.arcor-ip.net [47.66.24.155]) (authenticated bits=0) by services.gouders.net (8.14.8/8.14.8) with ESMTP id 09EJskwF025179 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Oct 2020 21:54:47 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gouders.net; s=gnet; t=1602705287; bh=jUoYd/A1gcN33exo0qYQZ5igyl8Jm6lM4h2RSJGFf1w=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=q90nZmaXhb1ArMz1IRWHC1xrdq9NnF3yNcV1YoxwVEIgux3RQP/FOwaCj49L/kqYm v3Rz/vw7XtOlsy3Nyht4JrI6K0WbwHhbBYqljnqYIph3PCl2RVgx8yi+HEce4+eLVB ZJHFWNKb+jq0oYwvviyk0aHrIDlPD5JqZLqWx9hs= From: Dirk Gouders To: James Bottomley Cc: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: WARN_ONCE triggered: tpm_tis: Add a check for invalid status In-Reply-To: <7729a41ac22dab84a785bc7a6228af28b814a33a.camel@HansenPartnership.com> (James Bottomley's message of "Wed, 14 Oct 2020 11:24:08 -0700") References: <7729a41ac22dab84a785bc7a6228af28b814a33a.camel@HansenPartnership.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Wed, 14 Oct 2020 21:54:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James Bottomley writes: > On Wed, 2020-10-14 at 19:57 +0200, Dirk Gouders wrote: >> On my laptop the check introduced with 55707d531af62b (tpm_tis: Add a >> check for invalid status) triggered the warning (output below). >> >> So, my laptop seems to be a candidate for testing. > > I'm afraid this is a known problem on a wide range of TIS TPMs ... it's > fixed by the patch set I'm trying to get upstream: > > https://lore.kernel.org/linux-integrity/20201001180925.13808-1-James.Bottomley@HansenPartnership.com/ > > But in the meantime, it's harmless. The TIS code at the point in the > trace is trying to send a TPM2_GetCapability() command which fails > because the locality isn't listening, but the design of that command is > only to trigger an interrupt to probe the interrupt handling nothing > else depends on it succeeding. Thank you for the explanation and sorry for the noise. It seems I misunderstood the commit message. I will watch the ongoing discussion you pointed me to. Dirk