From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B662A76040 for ; Mon, 29 Jan 2024 20:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706561847; cv=none; b=b97Ku4NFrkrYDLbvpzg14jIIfkh/00pJZIEqazN768ywtSElIDqnhlweeA4V2bc59EAFgKm3UAKz4GT288BM96baD2IEeTrxioR0NMJwur2FblMhB+OJSPk15a3Vr4GvP0rnxP9VhTZ7aT0v38+pyla4BoV+KaZWbq5BalYEie8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706561847; c=relaxed/simple; bh=2b0Fm92BYrv7od4rmimCRIjuTkKWHJKFkRBuhDCF5M8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GlJtwTy3z2Za4owR2DzamYPOK+gfb1lGe9mJ7ZWFR3zbo/6YdhxHUM6R3DmuIlX96jca5cpg55JCp+ZTzD+bLkqMCeuUt5c0cgf5mxLwCnelkP0KCMmNJL2MrMBQOVfJQqv8dOwYb6XZUQdquZ5OhDgd16Fl/CwPVIdlOgY1cRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dnDGjD7f; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dnDGjD7f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706561844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZpSdnNveS03uidkIaCRaoRGMyvrhYIOI4fp4SKhQKFg=; b=dnDGjD7foQGsbnJYwHaGjSBD2tvSuYHwBKcamyuo+SZtGrMtb4EwU7wnaAo9J943DZB9uX bk2SDBJACiuvq3ywVTVVenukiAIOMHudM8FWrzYQcMYETN4b1VyJPycDGqR4/HK6IyEjIu JTdlQNppALWbLI+8/xpZyXCTaI7+EH0= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-OTdA-E2JM-uzNO87THfMfw-1; Mon, 29 Jan 2024 15:57:23 -0500 X-MC-Unique: OTdA-E2JM-uzNO87THfMfw-1 Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-4bdc1d595c0so624962e0c.3 for ; Mon, 29 Jan 2024 12:57:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706561843; x=1707166643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZpSdnNveS03uidkIaCRaoRGMyvrhYIOI4fp4SKhQKFg=; b=umlc/cl2VzZq1DZhEgYF4s8dU+n0EazrDyUrz1559VoYp4+qAyCw5t9OisbA2oFqdG usiqbLhVlqvmO6qDz5OXb5jWgFNGJEtK1R0bkC/8Q3BtcOXB7Wc2a5/1sOz8Bu4SSOnu 3zDhPK8NT7mAokda24igH46cabz+qUDvD+x9pqE1HzpDhEs4P5GE71xmVSPEHHsgp91W iCzz/JMO46FDikQeGvyCLiHiJRD1UOPTaQ6NamE6aFEmW8kiu+vlXhqnSEVDvEQk7nlt jGHhJAPRTOCCegsQuI7xQNP0nhMI4m4bfTH/BAnmQ54NwFAZjb2AbBcRs7ruUXxVoGmE gvoA== X-Gm-Message-State: AOJu0YyfBpu4+8G5+IgOT98iKChrFGbRUo6AW/ienEoncQeLmlnXsMi2 LRIHoef06Zc7pUI1nnkXtLyTP3tXoTM8+vJ9KBHcgYPNLw0wlZHzQT2WG9GnLj8PN1J29B5EToc U/UjXNFXScZvcfeHt0UOcv7ylsAwufw+CJl8GZrrJak6z5lZNLV3umEw6UTSgPw== X-Received: by 2002:a05:6122:3a19:b0:4bd:800d:72ec with SMTP id fp25-20020a0561223a1900b004bd800d72ecmr2631124vkb.19.1706561842935; Mon, 29 Jan 2024 12:57:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrcccUSIgYBufwZZNxLHJdlcGzpJI+aaJovr7DFK+X2Rmv+DVoHH+zCYCUjPVWi9ptYcSCvQ== X-Received: by 2002:a05:6122:3a19:b0:4bd:800d:72ec with SMTP id fp25-20020a0561223a1900b004bd800d72ecmr2631106vkb.19.1706561842670; Mon, 29 Jan 2024 12:57:22 -0800 (PST) Received: from fedora ([2600:1700:1ff0:d0e0::47]) by smtp.gmail.com with ESMTPSA id qq2-20020a0562142c0200b0068c3f3752e5sm2671268qvb.116.2024.01.29.12.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 12:57:22 -0800 (PST) Date: Mon, 29 Jan 2024 14:57:20 -0600 From: Andrew Halaney To: Manivannan Sadhasivam Cc: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] scsi: ufs: qcom: Clarify the comment of core_reset property Message-ID: References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> <20240129-ufs-core-reset-fix-v1-2-7ac628aa735f@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129-ufs-core-reset-fix-v1-2-7ac628aa735f@linaro.org> On Mon, Jan 29, 2024 at 01:22:05PM +0530, Manivannan Sadhasivam wrote: > core_reset is not an optional property for the platforms supported in > upstream. Only for the non-upstreamed legacy platforms it is optional. > But somehow a few of the upstreamed platforms do not pass this property > by mistake. > > So clarify the comment to make it clear that even though core_reset is > required, it is kept as optional to support the DTs that do not pass this > property. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/ufs/host/ufs-qcom.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 39eef470f8fa..32760506dfeb 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1027,7 +1027,11 @@ static int ufs_qcom_init(struct ufs_hba *hba) > host->hba = hba; > ufshcd_set_variant(hba, host); > > - /* Setup the optional reset control of HCI */ > + /* > + * Even though core_reset is required on all platforms, some DTs never > + * passed this property. So we have to keep it optional for supporting > + * them. > + */ Any desire to print a warning if !host->core_reset? I'll defer to Qualcomm to review since they can confirm the accuracy past Can's comment, but this looks good to me for what its worth. > host->core_reset = devm_reset_control_get_optional(hba->dev, "rst"); > if (IS_ERR(host->core_reset)) { > err = dev_err_probe(dev, PTR_ERR(host->core_reset), > > -- > 2.25.1 > >