From: Andreas Schwab <schwab@suse.de>
To: James Morris <jmorris@namei.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH] selinux: endian fix
Date: Tue, 16 May 2006 18:24:14 +0200 [thread overview]
Message-ID: <jeiro6sztd.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0605161149540.16379@d.namei> (James Morris's message of "Tue, 16 May 2006 11:54:04 -0400 (EDT)")
James Morris <jmorris@namei.org> writes:
> On Tue, 16 May 2006, Alexey Dobriyan wrote:
>
>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> Hmm, I'm certain this was tested (perhaps on a BE machine, though).
ntohs and htons are identical operations. Either you swap or you don't,
but there is only one way to swap a short.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-05-16 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 15:23 [PATCH] selinux: endian fix Alexey Dobriyan
2006-05-16 15:54 ` James Morris
2006-05-16 16:24 ` Andreas Schwab [this message]
2006-05-16 16:30 ` James Morris
2006-05-16 16:34 ` Al Viro
2006-05-16 17:42 ` Jan Engelhardt
2006-05-16 17:50 ` Andreas Schwab
2006-05-17 0:55 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeiro6sztd.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).