From: Valentin Schneider <valentin.schneider@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: linux-next: Tree for Sep 8 (sched/topology.c)
Date: Tue, 08 Sep 2020 17:28:32 +0100 [thread overview]
Message-ID: <jhj1rjc6xn3.mognet@arm.com> (raw)
In-Reply-To: <jhj363s6ylu.mognet@arm.com>
On 08/09/20 17:07, Valentin Schneider wrote:
> On 08/09/20 16:50, Randy Dunlap wrote:
>> Sure, here it is again. And
>> CONFIG_SMP=y
>> CONFIG_SCHED_DEBUG=y
>>
>> thanks.
>
> Okay so I can reproduce that with GCC-10.1, now to figure out WTH is going on...
Yet another fail from my end, the declaration is conditioned by:
CONFIG_SCHED_DEBUG
CONFIG_SMP
CONFIG_SYSCTL
that last one being ofc stupid. Below lets me build; I'll go get
something with caffeine in it and double-check the shuffles I've done
before sending an actual patch.
Thanks for the report!
---
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 0d7896d2a0b2..0ca486aa296b 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -185,6 +185,12 @@ late_initcall(sched_init_debug);
#ifdef CONFIG_SMP
+#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
+const struct sd_flag_debug sd_flag_debug[] = {
+#include <linux/sched/sd_flags.h>
+};
+#undef SD_FLAG
+
#ifdef CONFIG_SYSCTL
static struct ctl_table sd_ctl_dir[] = {
@@ -245,12 +251,6 @@ set_table_entry(struct ctl_table *entry,
entry->proc_handler = proc_handler;
}
-#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
-const struct sd_flag_debug sd_flag_debug[] = {
-#include <linux/sched/sd_flags.h>
-};
-#undef SD_FLAG
-
static int sd_ctl_doflags(struct ctl_table *table, int write,
void *buffer, size_t *lenp, loff_t *ppos)
{
---
next prev parent reply other threads:[~2020-09-08 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 10:56 linux-next: Tree for Sep 8 Stephen Rothwell
2020-09-08 14:47 ` linux-next: Tree for Sep 8 (sched/topology.c) Randy Dunlap
2020-09-08 15:03 ` Vincent Guittot
2020-09-08 15:47 ` Valentin Schneider
2020-09-08 15:50 ` Randy Dunlap
2020-09-08 16:07 ` Valentin Schneider
2020-09-08 16:28 ` Valentin Schneider [this message]
2020-09-08 17:17 ` Randy Dunlap
2020-09-08 16:25 ` linux-next: Tree for Sep 8 (net/ipv4/ip_tunnel.o) Randy Dunlap
2020-09-08 17:12 ` linux-next: Tree for Sep 8 (drivers/mmc/host/meson-gx-mmc.o) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhj1rjc6xn3.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).