From: Valentin Schneider <valentin.schneider@arm.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Thara Gopinath <thara.gopinath@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: v5.7: new core kernel option missing help text
Date: Fri, 05 Jun 2020 11:02:00 +0100 [thread overview]
Message-ID: <jhj7dwlj0fb.mognet@arm.com> (raw)
In-Reply-To: <20200605081518.GG1551@shell.armlinux.org.uk>
On 05/06/20 09:15, Russell King - ARM Linux admin wrote:
> On Thu, Jun 04, 2020 at 04:38:40PM +0100, Valentin Schneider wrote:
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 74a5ac65644f..ba846f6e805b 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -439,8 +439,11 @@ config HAVE_SCHED_AVG_IRQ
>> depends on SMP
>>
>> config SCHED_THERMAL_PRESSURE
>> - bool "Enable periodic averaging of thermal pressure"
>> + def_bool n
>
> You don't need to specify this default, as the default default is "n".
> "bool" will do.
>
> You should never need to use "def_bool n" or "default n" for anything
> this simple. There are more complex cases where there may be multiple
> conditional "default" lines where it may be necessary, but the majority
> of cases where people use these are completely unnecessary.
Right, thanks!
prev parent reply other threads:[~2020-06-05 10:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 17:31 v5.7: new core kernel option missing help text Russell King - ARM Linux admin
2020-06-03 18:00 ` Valentin Schneider
2020-06-03 18:45 ` Russell King - ARM Linux admin
2020-06-03 19:24 ` Vincent Guittot
2020-06-03 19:58 ` Russell King - ARM Linux admin
2020-06-03 20:22 ` Vincent Guittot
2020-06-03 20:25 ` Valentin Schneider
2020-06-04 0:48 ` Thara Gopinath
2020-06-04 9:26 ` Valentin Schneider
2020-06-04 9:29 ` Russell King - ARM Linux admin
2020-06-04 10:56 ` Valentin Schneider
[not found] ` <CALD-y_zQms4YQup2MgAfNhWSu=ewkhossHma2TKqfTcOFaG=uA@mail.gmail.com>
2020-06-04 15:38 ` Valentin Schneider
2020-06-04 22:22 ` Thara Gopinath
2020-06-05 7:03 ` Vincent Guittot
2020-06-05 9:46 ` Valentin Schneider
2020-06-05 8:15 ` Russell King - ARM Linux admin
2020-06-05 10:02 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhj7dwlj0fb.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).