From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
linux-kernel@vger.kernel.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH 2/3 v2] sched/fair: don't set LBF_ALL_PINNED unnecessarily
Date: Thu, 07 Jan 2021 11:26:34 +0000 [thread overview]
Message-ID: <jhjeeixasyd.mognet@arm.com> (raw)
In-Reply-To: <20210107103325.30851-3-vincent.guittot@linaro.org>
On 07/01/21 11:33, Vincent Guittot wrote:
> Setting LBF_ALL_PINNED during active load balance is only valid when there
> is only 1 running task on the rq otherwise this ends up increasing the
> balance interval whereas other tasks could migrate after the next interval
> once they become cache-cold as an example.
>
> LBF_ALL_PINNED flag is now always set it by default. It is then cleared
> when we find one task that can be pulled when calling detach_tasks() or
> during active migration.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
next prev parent reply other threads:[~2021-01-07 11:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 10:33 [PATCH 0/3 v2] Reduce number of active LB Vincent Guittot
2021-01-07 10:33 ` [PATCH 1/3 v2] sched/fair: skip idle cfs_rq Vincent Guittot
2021-01-11 14:46 ` Mel Gorman
2021-01-14 11:29 ` [tip: sched/core] sched/fair: Skip " tip-bot2 for Vincent Guittot
2021-01-07 10:33 ` [PATCH 2/3 v2] sched/fair: don't set LBF_ALL_PINNED unnecessarily Vincent Guittot
2021-01-07 11:26 ` Valentin Schneider [this message]
[not found] ` <BN8PR12MB2978EC9CFBAF529C527D05919AAF0@BN8PR12MB2978.namprd12.prod.outlook.com>
2021-01-07 16:00 ` Vincent Guittot
2021-01-11 15:42 ` Mel Gorman
2021-01-14 11:29 ` [tip: sched/core] sched/fair: Don't " tip-bot2 for Vincent Guittot
2021-01-07 10:33 ` [PATCH 3/3 v2] sched/fair: reduce cases for active balance Vincent Guittot
2021-01-07 11:26 ` Valentin Schneider
2021-01-07 12:20 ` Vincent Guittot
2021-01-07 17:40 ` Valentin Schneider
2021-01-08 8:11 ` Vincent Guittot
2021-01-08 14:36 ` Valentin Schneider
2021-01-12 9:16 ` Mel Gorman
2021-01-14 11:29 ` [tip: sched/core] sched/fair: Reduce " tip-bot2 for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjeeixasyd.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).