From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4CCDC2BB1D for ; Tue, 14 Apr 2020 20:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8BF720644 for ; Tue, 14 Apr 2020 20:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633501AbgDNU5k (ORCPT ); Tue, 14 Apr 2020 16:57:40 -0400 Received: from foss.arm.com ([217.140.110.172]:34490 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2633476AbgDNU4v (ORCPT ); Tue, 14 Apr 2020 16:56:51 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 694451FB; Tue, 14 Apr 2020 13:56:47 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EFF53F73D; Tue, 14 Apr 2020 13:56:45 -0700 (PDT) References: <20200414150556.10920-1-qais.yousef@arm.com> <20200414162742.0ef4d9ee@gandalf.local.home> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Steven Rostedt Cc: Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Andrew Morton , Thomas Gleixner , Yury Norov , Paul Turner , Alexey Dobriyan , Josh Don , Pavan Kondeti , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] sched/rt: Distribute tasks in find_lowest_rq() In-reply-to: <20200414162742.0ef4d9ee@gandalf.local.home> Date: Tue, 14 Apr 2020 21:56:43 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/20 21:27, Steven Rostedt wrote: > On Tue, 14 Apr 2020 19:58:49 +0100 > Valentin Schneider wrote: > >> To move this forward, I would suggest renaming the current cpumask_any_*() >> into cpumask_first_*(), and THEN introduce the new pseudo-random >> ones. People are then free to hand-fix specific locations if it makes sense >> there, like you're doing for RT. > > Or leave "cpumask_any()" as is, and create a new "cpumask_random()" for > this purpose. > Sure; I'll be happy as long as there isn't a blanket replacement of existing callsites. > -- Steve