From: Valentin Schneider <valentin.schneider@arm.com>
To: Tao Zhou <ouwen210@hotmail.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org, morten.rasmussen@arm.com
Subject: Re: [PATCH v2] sched/fair: prefer prev cpu in asymmetric wakeup path
Date: Thu, 29 Oct 2020 12:24:45 +0000 [thread overview]
Message-ID: <jhjimatp6cy.mognet@arm.com> (raw)
In-Reply-To: <BN8PR12MB2978D627EE0D6456DC2EEA6B9A140@BN8PR12MB2978.namprd12.prod.outlook.com>
On 29/10/20 12:17, Tao Zhou wrote:
> Hi Vincent,
>
> On Wed, Oct 28, 2020 at 06:44:12PM +0100, Vincent Guittot wrote:
>> @@ -6173,20 +6173,20 @@ static int
>> select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int target)
>> {
>> unsigned long best_cap = 0;
>> - int cpu, best_cpu = -1;
>> + int task_util, cpu, best_cpu = -1;
>> struct cpumask *cpus;
>>
>> - sync_entity_load_avg(&p->se);
>> -
>> cpus = this_cpu_cpumask_var_ptr(select_idle_mask);
>> cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr);
>>
>> + task_util = uclamp_task_util(p);
>
> The return type of uclamp_task_util() is *unsigned long*.
> But, task_util is *int*.
>
> @Valentin: I checked that the return type of uclamp_task_util()
> is changed from unsigned int to unsigned long by you
>
Indeed, IIRC I stated in that changelog that the canonical type for
utilization / capacity values is unsigned long.
next prev parent reply other threads:[~2020-10-29 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 17:44 [PATCH v2] sched/fair: prefer prev cpu in asymmetric wakeup path Vincent Guittot
2020-10-29 11:16 ` Valentin Schneider
2020-10-29 13:58 ` Vincent Guittot
2020-10-29 14:19 ` Vincent Guittot
2020-10-29 14:30 ` Vincent Guittot
2020-10-29 14:33 ` Vincent Guittot
2020-10-29 14:45 ` Valentin Schneider
[not found] ` <BN8PR12MB2978D627EE0D6456DC2EEA6B9A140@BN8PR12MB2978.namprd12.prod.outlook.com>
2020-10-29 12:24 ` Valentin Schneider [this message]
2020-10-29 13:49 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjimatp6cy.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=ouwen210@hotmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).