archive mirror
 help / color / mirror / Atom feed
From: Valentin Schneider <>
To: kernel test robot <>
	Vincent Donnefort <>
Subject: Re: [PATCH] sched/debug: Add new tracepoint to track cpu_capacity
Date: Thu, 27 Aug 2020 20:24:03 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 27/08/20 20:08, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>>> kernel/sched/fair.c:11314:18: error: no member named 'cpu_capacity' in 'struct rq'
>            return rq ? rq->cpu_capacity : -1;
>                        ~~  ^
>    1 error generated.

The joys of !SMP; you'll want to wrap this in an #ifdef CONFIG_SMP like
some of the other TP's. The !SMP case can probably return
SCHED_CAPACITY_SCALE for the sake of pedantism, AFAICT that TP can't fire
on !SMP (that, or only define it for SMP).

      reply	other threads:[~2020-08-27 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 15:35 vincent.donnefort
2020-08-27 19:08 ` kernel test robot
2020-08-27 19:24   ` Valentin Schneider [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] sched/debug: Add new tracepoint to track cpu_capacity' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).