From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752622AbcGVQiF (ORCPT ); Fri, 22 Jul 2016 12:38:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40927 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbcGVQiD (ORCPT ); Fri, 22 Jul 2016 12:38:03 -0400 From: Bandan Das To: Paolo Bonzini Cc: Dave Jones , Linux Kernel , Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm@vger.kernel.org Subject: Re: RFC: silencing kvm unimplemented msr spew. References: <20160715192729.GA4712@fb.com> <110045299.8101686.1468855610053.JavaMail.zimbra@redhat.com> <20160719195856.GA31453@fb.com> <20160721202440.GA10908@fb.com> <844431780.9635789.1469177321917.JavaMail.zimbra@redhat.com> <1171934212.9737926.1469204427109.JavaMail.zimbra@redhat.com> Date: Fri, 22 Jul 2016 12:37:58 -0400 In-Reply-To: <1171934212.9737926.1469204427109.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Fri, 22 Jul 2016 12:20:27 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 22 Jul 2016 16:38:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini writes: >> >> Paolo, would you prefer this, or the other approach you already ack'd ? >> > >> > I think I prefer the other, because vcpu_debug is not ratelimited. >> > If the guest can trigger a printk it should always be ratelimited. >> >> Agree with rate limiting, but making this the default for everything doesn't >> sound right IMO, especially for ignore_msrs=1. vcpu_unimpl is already rate >> limited. > > The problem is that your patch removes rate limiting whenever it now > uses vcpu_debug. I was suggesting Dave to do something like what I posted but with a new vcpu_debug_ratelimited. > Paolo