From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbbEFSPQ (ORCPT ); Wed, 6 May 2015 14:15:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43543 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbbEFSPN convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 14:15:13 -0400 From: Bandan Das To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, guangrong.xiao@linux.intel.com, Yang Zhang , wanpeng.li@linux.intel.com Subject: Re: [PATCH 12/13] KVM: x86: add KVM_MEM_X86_SMRAM memory slot flag References: <1430393772-27208-1-git-send-email-pbonzini@redhat.com> <1430393772-27208-13-git-send-email-pbonzini@redhat.com> <20150505171747.GB17198@potion.brq.redhat.com> <5549E337.1090606@redhat.com> <20150506162437.GA27205@potion.brq.redhat.com> Date: Wed, 06 May 2015 14:15:09 -0400 In-Reply-To: <20150506162437.GA27205@potion.brq.redhat.com> ("Radim \=\?utf-8\?B\?S3LEjW3DocWZIidz\?\= message of "Wed, 6 May 2015 18:24:41 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Radim Krčmář writes: ... > > That doesn't improve the main issue, so x86 is good. > >>> Another option is adding something like "vcpu kvm_arch_fake_vcpu(kvm)" >>> for cases where the access doesn't have an associated vcpu, so it would >>> always succeed. (Might not be generic enough.) >> >> That's ugly... > > Yes. (And I still prefer it.) Ooh, I hope we don't go this route :) I understand the motivation but if there would be cases where we would have to fake the condition to be true, maybe we should reconsider our design. Bandan