From: Stefan Monnier <monnier@iro.umontreal.ca>
To: linux-kernel@vger.kernel.org
Cc: linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite
Date: Tue, 07 Mar 2017 23:16:59 -0500 [thread overview]
Message-ID: <jwvmvcwflnm.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org> (raw)
In-Reply-To: CAGb2v67iTOV-=u5rReu6_wi6NFoCoJkbJKshTpmFYUmJ=ggKUw@mail.gmail.com
>> + if (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
>> + val = 1;
>> + else
>> + val = 0;
Isn't this better written as
val = (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC);
-- Stefan
next prev parent reply other threads:[~2017-03-08 4:57 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 8:56 [PATCH 0/15] drm: sun4i: Add support for the HDMI controller Maxime Ripard
2017-03-07 8:56 ` [PATCH 1/15] clk: divider: Make divider_round_rate take the parent clock Maxime Ripard
2017-03-07 14:11 ` Stephen Boyd
2017-03-09 10:55 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 2/15] clk: sunxi-ng: Pass the parent and a pointer to the clocks round rate Maxime Ripard
2017-03-07 8:56 ` [PATCH 3/15] clk: sunxi-ng: div: Switch to divider_round_rate Maxime Ripard
2017-03-07 8:56 ` [PATCH 4/15] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT Maxime Ripard
2017-03-07 8:56 ` [PATCH 5/15] clk: sunxi-ng: sun5i: Export video PLLs Maxime Ripard
2017-03-07 10:21 ` [linux-sunxi] " Julian Calaby
2017-03-08 8:58 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings Maxime Ripard
2017-03-08 3:39 ` Chen-Yu Tsai
2017-03-15 17:26 ` Rob Herring
2017-04-03 20:59 ` Maxime Ripard
2017-05-03 3:27 ` Chen-Yu Tsai
2017-03-07 8:56 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Maxime Ripard
2017-03-08 3:38 ` Chen-Yu Tsai
2017-03-15 17:37 ` Rob Herring
2017-03-17 3:34 ` Chen-Yu Tsai
2017-03-26 21:11 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 8/15] drm/sun4i: tcon: Add channel debug Maxime Ripard
2017-03-08 3:37 ` Chen-Yu Tsai
2017-03-07 8:56 ` [PATCH 9/15] drm/sun4i: tcon: Pass the encoder to the mode set functions Maxime Ripard
2017-03-07 8:56 ` [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite Maxime Ripard
2017-03-08 3:51 ` Chen-Yu Tsai
2017-03-08 4:16 ` Stefan Monnier [this message]
2017-03-09 10:58 ` Maxime Ripard
2017-03-09 11:31 ` [linux-sunxi] " Chen-Yu Tsai
2017-03-09 14:55 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Maxime Ripard
2017-03-08 4:25 ` Chen-Yu Tsai
2017-03-08 8:55 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 12/15] drm/sun4i: tcon: multiply the vtotal when not in interlace Maxime Ripard
2017-03-07 10:05 ` Chen-Yu Tsai
2017-03-09 10:54 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 13/15] drm/sun4i: Add HDMI support Maxime Ripard
2017-04-21 15:17 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-26 6:50 ` Maxime Ripard
2017-04-26 7:59 ` Chen-Yu Tsai
2017-05-03 8:41 ` Maxime Ripard
2017-03-07 8:56 ` [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI controller node Maxime Ripard
2017-03-08 3:35 ` [linux-sunxi] " Chen-Yu Tsai
2017-03-09 10:59 ` Maxime Ripard
2017-03-09 11:10 ` Chen-Yu Tsai
2017-03-07 8:56 ` [PATCH 15/15] ARM: sun5i: a10s-olinuxino: Enable HDMI Maxime Ripard
2017-03-08 3:36 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmvcwflnm.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).