From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C77EC43381 for ; Thu, 7 Jan 2021 16:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 724F923118 for ; Thu, 7 Jan 2021 16:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728535AbhAGQEb (ORCPT ); Thu, 7 Jan 2021 11:04:31 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:30878 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726780AbhAGQEa (ORCPT ); Thu, 7 Jan 2021 11:04:30 -0500 Date: Thu, 07 Jan 2021 16:03:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1610035427; bh=NjLJYtrwGi8fl20fDTPPgaGJm/yzsWtQLjMz/qlJmLk=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=lJFxtxag81erccYTjlMGJWfmCu/2PURzR6TdJ4oSGuwrv48rv+4ZCfybs62jPISY+ h1bj48txohaisl7Mi9NJnA8O1jvKX2M0+/jB9Fh6jbGgX/wVejN5PmIH/OMzV3CV8u SiHxLtOIZu1ZMn9L2OdHhkyMsHYEXgvRlX0nyZ8s= To: Hans de Goede From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Perry Yuan , "mgross@linux.intel.com" , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Limonciello Mario Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Subject: Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Message-ID: In-Reply-To: References: <20201228132855.17544-1-Perry_Yuan@Dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi 2021. janu=C3=A1r 7., cs=C3=BCt=C3=B6rt=C3=B6k 0:43 keltez=C3=A9ssel, Hans = de Goede =C3=ADrta: > Hi Perry, > > On 12/28/20 2:28 PM, Perry Yuan wrote: > > > From: Perry Yuan perry_yuan@dell.com > > add support for dell privacy driver for the dell units equipped > > hardware privacy design, which protect users privacy > > of audio and camera from hardware level. once the audio or camera > > privacy mode enabled, any applications will not get any audio or > > video stream. > > when user pressed ctrl+F4 hotkey, audio privacy mode will be > > enabled,Micmute led will be also changed accordingly. > > The micmute led is fully controlled by hardware & EC. > > and camera mute hotkey is ctrl+F9.currently design only emmit > > SW_CAMERA_LENS_COVER event while the camera LENS shutter will be > > changed by EC & HW control. > > *The flow is like this: > > > > 1. User presses key. HW does stuff with this key (timeout is started) > > 2. Event is emitted from FW > > 3. Event received by dell-privacy > > 4. KEY_MICMUTE emitted from dell-privacy > > 5. Userland picks up key and modifies kcontrol for SW mute > > 6. Codec kernel driver catches and calls ledtrig_audio_set, like this: > > ledtrig_audio_set(LED_AUDIO_MICMUTE, > > rt715->micmute_led ? LED_ON :LED_OFF); > > > > 7. If "LED" is set to on dell-privacy notifies ec, > > and timeout is cancelled,HW mic mute activated. > > > > > > Signed-off-by: Perry Yuan perry_yuan@dell.com > > Signed-off-by: Limonciello Mario mario_limonciello@dell.com > > Thank you for your patch, please send a new version addressing > Barnab=C3=A1s' review comment and including the second patch of the > series. > [...] I think first something needs to be figured out regarding the integration with the rest of the Dell modules. I feel that list is not a desirable way to do it. Regards, Barnab=C3=A1s P=C5=91cze