From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760925AbYENJKp (ORCPT ); Wed, 14 May 2008 05:10:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759766AbYENJKT (ORCPT ); Wed, 14 May 2008 05:10:19 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:55618 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758348AbYENJKO (ORCPT ); Wed, 14 May 2008 05:10:14 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Andrew Morton Cc: Randy Dunlap , Greg KH , Al Viro , Benjamin Thery , Greg KH , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Daniel Lezcano , Pavel Emelyanov , "Serge E. Hallyn" , Tejun Heo References: <20080512220232.GA16914@kroah.com> <4829A4BD.3020007@bull.net> <20080513164438.GA31563@kroah.com> <20080513201602.GA31578@kroah.com> <24291087.1210713535895.JavaMail.oracle@acsmt301.oracle.com> <20080513220304.b2f5a588.akpm@linux-foundation.org> Date: Wed, 14 May 2008 02:01:37 -0700 In-Reply-To: <20080513220304.b2f5a588.akpm@linux-foundation.org> (Andrew Morton's message of "Tue, 13 May 2008 22:03:04 -0700") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4 X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on mgr1.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: >> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h >> index 7858eac..6e61033 100644 >> --- a/include/linux/sysfs.h >> +++ b/include/linux/sysfs.h >> @@ -20,6 +20,8 @@ >> struct kobject; >> struct module; >> >> +extern int kobject_set_name(struct kobject *kobj, const char *name, ...) >> + __attribute__((format(printf, 2, 3))); > > Duplicating the kobject_set_name() declaration in sysfs.h is rather a hack. A bit. It really isn't worse then a struct declaration like struct kobject; > It'd be better to move it into a new header file, included by both > sysfs.h and kobject.h. Perhaps there are other declarations which can > be moved with it. My gut feel says that sysfs.h should include kobject.h instead of the other way around. However it gets reorganized, it is an entirely separate problem from the one this patch sets out to solve and so should go in a different patch. Eric