From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262824AbVAFNxL (ORCPT ); Thu, 6 Jan 2005 08:53:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262826AbVAFNxL (ORCPT ); Thu, 6 Jan 2005 08:53:11 -0500 Received: from one.firstfloor.org ([213.235.205.2]:62650 "EHLO one.firstfloor.org") by vger.kernel.org with ESMTP id S262824AbVAFNwl (ORCPT ); Thu, 6 Jan 2005 08:52:41 -0500 To: Christoph Lameter Cc: linux-kernel@vger.kernel.org Subject: Re: Prezeroing V3 [2/4]: Extension of clear_page to take an order parameter References: <41C20E3E.3070209@yahoo.com.au> From: Andi Kleen Date: Thu, 06 Jan 2005 14:52:36 +0100 In-Reply-To: (Christoph Lameter's message of "Wed, 5 Jan 2005 15:25:20 -0800 (PST)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter writes: > Here is an updated version that is independent of the first patch and > contains all the necessary modifications to make clear_page take a second > parameter. I still think the clear_page order addition is completely pointless, because for > order 0 you probably want a cache bypassing store in a separate function. Removing it would also make the patch much less intrusive. -Andi