From: ebiederm@xmission.com (Eric W. Biederman)
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: bug on shutdown from 68-mm4 (machine_power_off returning causes problems)
Date: 11 May 2003 12:37:48 -0600 [thread overview]
Message-ID: <m17k8x72ir.fsf_-_@frodo.biederman.org> (raw)
In-Reply-To: <12530000.1052664451@[10.10.2.4]>
"Martin J. Bligh" <mbligh@aracnet.com> writes:
> >> >> Sorry if this is old news, haven't been paying attention for a week.
> >> >> Bug on shutdown (just after it says "Power Down") from 68-mm4.
> >> >> (the NUMA-Q).
> >> >
> >> > Random guess: is it related to CONFIG_KEXEC?
> >>
> >> Don't think so - I don't have that enabled. Config file is attatched.
> >
> > It doesn't matter - the kexec patch tends to futz with stuff like that
> > regardless of CONFIG_KEXEC.
> >
> > It doesn't happen here. Could you please retest without the kexec
> > patch applied?
>
> Yup, backing out kexec fixes it.
Ok. Thinking it through the differences is that I have machine_power_off
call stop_apics (which is roughly equivalent to the old smp_send_stop).
In the kexec patch that does 2 things.
1) It shuts down the secondary cpus, and returns the bootstrap cpu to
virtual wire mode.
2) It calls set_cpus_allowed to force the reboot to be on the primary
cpu.
After returning from machine_power_off. We run into a problem
in flush_tlb_mm. Because we have a cpu disabled, that is still part
of the mm's vm mask.
Does anyone know why machine_halt, and machine_power_off return?
If not I am just going to disable the return path.
Eric
next prev parent reply other threads:[~2003-05-11 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-11 3:25 bug on shutdown from 68-mm4 Martin J. Bligh
2003-05-11 5:44 ` Andrew Morton
2003-05-11 3:36 ` Martin J. Bligh
2003-05-11 6:11 ` Andrew Morton
2003-05-11 14:47 ` Martin J. Bligh
2003-05-11 18:37 ` Eric W. Biederman [this message]
2003-05-12 3:30 ` bug on shutdown from 68-mm4 (machine_power_off returning causes problems) Martin J. Bligh
2003-05-12 13:37 ` Eric W. Biederman
2003-05-12 12:43 ` Martin J. Bligh
2003-05-13 9:35 ` Eric W. Biederman
2003-05-14 17:27 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17k8x72ir.fsf_-_@frodo.biederman.org \
--to=ebiederm@xmission.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).