From: ebiederm@xmission.com (Eric W. Biederman)
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Russell King <rmk@arm.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Patrick Mochel <mochel@osdl.org>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] don't call device_shutdown on halt.
Date: 17 Aug 2003 16:26:36 -0600 [thread overview]
Message-ID: <m1fzjzyl7n.fsf_-_@frodo.biederman.org> (raw)
In-Reply-To: <m1wudgxiab.fsf@frodo.biederman.org>
For a halt quiescing devices is overkill, historically wrong, and
error prone when the system is halted. The only drivers that should
care are drivers for devices that do the wrong thing when power is
removed.
diff -uNr linux-2.6.0-test3/kernel/sys.c linux-2.6.0-test3-no_device_shutdown/kernel/sys.c
--- linux-2.6.0-test3/kernel/sys.c Tue Jul 29 14:48:17 2003
+++ linux-2.6.0-test3-no_device_shutdown/kernel/sys.c Sun Aug 17 22:04:18 2003
@@ -423,7 +423,6 @@
case LINUX_REBOOT_CMD_HALT:
notifier_call_chain(&reboot_notifier_list, SYS_HALT, NULL);
system_running = 0;
- device_shutdown();
printk(KERN_EMERG "System halted.\n");
machine_halt();
unlock_kernel();
@@ -433,7 +432,6 @@
case LINUX_REBOOT_CMD_POWER_OFF:
notifier_call_chain(&reboot_notifier_list, SYS_POWER_OFF, NULL);
system_running = 0;
- device_shutdown();
printk(KERN_EMERG "Power down.\n");
machine_power_off();
unlock_kernel();
next prev parent reply other threads:[~2003-08-17 22:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-14 7:06 [PATCH] call drv->shutdown at rmmod Eric W. Biederman
2003-08-14 7:54 ` Christoph Hellwig
2003-08-14 8:06 ` Russell King
2003-08-14 15:50 ` Eric W. Biederman
2003-08-14 16:07 ` Russell King
2003-08-14 17:26 ` Eric W. Biederman
2003-08-17 22:26 ` Eric W. Biederman [this message]
2003-08-14 16:40 ` Russell King
2003-08-14 16:02 ` Patrick Mochel
2003-08-14 16:26 ` Eric W. Biederman
2003-08-14 16:41 ` Patrick Mochel
2003-08-14 17:41 ` Eric W. Biederman
2003-08-15 8:51 ` Benjamin Herrenschmidt
2003-08-15 15:28 ` Eric W. Biederman
2003-08-15 16:01 ` Benjamin Herrenschmidt
2003-08-15 16:30 ` Patrick Mochel
2003-08-14 16:47 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fzjzyl7n.fsf_-_@frodo.biederman.org \
--to=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).