From: ebiederm@xmission.com (Eric W. Biederman)
To: Len Brown <lenb@kernel.org>
Cc: Cong Wang <amwang@redhat.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, Takao Indoh <tindoh@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [Patch] acpi: introduce "acpi_addr=" parameter for kdump
Date: Tue, 22 Mar 2011 21:36:33 -0700 [thread overview]
Message-ID: <m1lj06zc4u.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1103230026170.10549@x980> (Len Brown's message of "Wed, 23 Mar 2011 00:28:21 -0400 (EDT)")
Len Brown <lenb@kernel.org> writes:
> On Mon, 21 Mar 2011, Cong Wang wrote:
>
>> 于 2011年03月11日 00:26, Randy Dunlap 写道:
>> > On Thu, 10 Mar 2011 22:10:43 +0800 Amerigo Wang wrote:
>> > > + acpi_addr= [ACPI,EFI]
>> > > + Pass the RSDP address to the kernel, mostly used
>> > > + on machines running EFI runtime service to boot the
>> > > + second kernel for kdump.
>> > > +
>> >
>> > I think that "acpi_addr" is a bit too generic. How about
>> > acpi_rsdp or acpi_root instead?
>> >
>>
>> Yup, I agree "acpi_rsdp" is better.
>
> This should also be [KEXEC], and the code should be #ifdef CONFIG_KEXEC
> so that sane people can exclude it from their kernels.
So far sane people don't use EFI on x86 so that is easy enough.
Eric
next prev parent reply other threads:[~2011-03-23 4:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 14:10 [Patch] acpi: introduce "acpi_addr=" parameter for kdump Amerigo Wang
2011-03-10 14:39 ` Vivek Goyal
2011-03-10 15:59 ` Takao Indoh
2011-03-10 17:50 ` Eric W. Biederman
2011-03-10 18:50 ` Matthew Garrett
2011-03-21 6:40 ` Cong Wang
2011-03-21 8:05 ` Eric W. Biederman
2011-03-21 15:56 ` Vivek Goyal
2011-03-22 6:31 ` Cong Wang
2011-03-10 16:26 ` Randy Dunlap
2011-03-21 6:43 ` Cong Wang
2011-03-23 4:28 ` Len Brown
2011-03-23 4:36 ` Eric W. Biederman [this message]
2011-03-23 17:40 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1lj06zc4u.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=amwang@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tindoh@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).