linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, pageexec@freemail.hu
Subject: Re: [PATCH] fix x86-32 early fixmap initialization.
Date: Sat, 01 Dec 2007 19:32:29 -0700	[thread overview]
Message-ID: <m1lk8d3jya.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <86802c440712011824v4fdac3c4pfaf2f4d5ce93fe18@mail.gmail.com> (Yinghai Lu's message of "Sat, 1 Dec 2007 18:24:55 -0800")

"Yinghai Lu" <yhlu.kernel@gmail.com> writes:

> On Dec 1, 2007 5:34 PM, Eric W. Biederman <ebiederm@xmission.com> wrote:
>>
>> pageexec@freemail.hu writes:
>>
>> > hello,
>> >
>> > i've just noticed that the chunk in i386/kernel/head.S ended up in a
>> > weird place, namely, it's not going to be executed as it's just after
>> > a 'jmp 3f' and before startup_32_smp, probably not what you intended.
>> > on a sidenote, the whole thing can be done in a single insn, like:
>> >
>> > movl $(swapper_pg_pmd - __PAGE_OFFSET + 0x067), (swapper_pg_dir -
>> > __PAGE_OFFSET+ 4092)
>> >
>> > PS: your email address ebiderman@xmisson.com in the commit seems to
>> > be wrong as well.
>>
>> Yes.  YH refresh one of my old patches and apparently got my email
>> address wrong.
>>
>> Thanks for the reminder I thought we had fixed this problem a while ago.
>
> i sent fix to andrew and andi. but it seems they missed it.

Well hopefully the new arch/x86 maintainers can pick up a simple bug fix.
Hopefully this code has not bit-rotted yet.

> BTW: how about your head32.c patch series.

I think it is a wonderful idea ;)

Right now I'm buried in the namespace work.

I am seeing my todo list shrink visibly on that day by day, but it is
still a mighty list.

Hopefully that list will won't include any patches that just need refreshing
and merging by the time 2.6.25 rolls around...

Eric

  reply	other threads:[~2007-12-02  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <47520F37.20657.4A6846F1@pageexec.freemail.hu>
2007-12-02  1:34 ` [PATCH] fix x86-32 early fixmap initialization Eric W. Biederman
2007-12-02  2:24   ` Yinghai Lu
2007-12-02  2:32     ` Eric W. Biederman [this message]
2007-12-04 12:51     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1lk8d3jya.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pageexec@freemail.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).