From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932419AbWGEPxb (ORCPT ); Wed, 5 Jul 2006 11:53:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932422AbWGEPxa (ORCPT ); Wed, 5 Jul 2006 11:53:30 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:20146 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S932419AbWGEPxa (ORCPT ); Wed, 5 Jul 2006 11:53:30 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Edgar Hucek Cc: "H. Peter Anvin" , Linus Torvalds , LKML , akpm@osdl.org Subject: Re: [PATCH 1/1] Fix boot on efi 32 bit Machines [try #4] References: <44A04F5F.8030405@ed-soft.at> <44A0CCEA.7030309@ed-soft.at> <44A304C1.2050304@zytor.com> <44A8058D.3030905@zytor.com> <44AB8878.7010203@ed-soft.at> Date: Wed, 05 Jul 2006 09:52:48 -0600 In-Reply-To: <44AB8878.7010203@ed-soft.at> (Edgar Hucek's message of "Wed, 05 Jul 2006 11:38:00 +0200") Message-ID: User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Edgar Hucek writes: > I agre with you to make efi use the e820 map as a long term solution. > But at the moment the efi part is completley broken without my patch. But your patch isn't a fix. It is a hack to make the system boot. A patch that performed the same check on the efi memory map, or it converted the efi memory map to use an e820 map it would be a fix. > At least on Intel Macs. > Without the patch also my Imacfb driver makes no sense, since it is > for efi booted Intel Macs. My point is that the kernel efi support is broken. You have just found the location where the bone is poking through the skin. I am tempted to write a patch to delete the x86 efi support at this point. So that it is very clear that it needs to be completely redone. Eric