From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753718AbYGFEwK (ORCPT ); Sun, 6 Jul 2008 00:52:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751120AbYGFEvy (ORCPT ); Sun, 6 Jul 2008 00:51:54 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:51499 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbYGFEvx (ORCPT ); Sun, 6 Jul 2008 00:51:53 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Greg Kroah-Hartman Cc: Andrew Morton , Tejun Heo , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Benjamin Thery , , Cornelia Huck References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.002784342@theryb.frec.bull.fr> <485F04E1.70204@gmail.com> <486706C9.9040303@gmail.com> <4869D314.5030403@gmail.com> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> <486C4515.1070007@gmail.com> <486CB051.5000507@fr.ibm.com> <486CF71F.5090405@gmail.com> Date: Sat, 05 Jul 2008 21:42:57 -0700 In-Reply-To: (Eric W. Biederman's message of "Thu, 03 Jul 2008 17:48:40 -0700") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Greg Kroah-Hartman X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -1.1 BAYES_05 BODY: Bayesian spam probability is 1 to 5% * [score: 0.0202] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH 00/15] sysfs support for namespaces X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on mgr1.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > These patches are based off of 2.6.26-rc8 + the -gregkh tree from > last night. Hopefully that means they apply -mm -gregkh and > -linux-next. A quick update. My patchset conflicts with the recently added driver-core-suppress-sysfs-warnings-for-device_rename.patch > driver core: Suppress sysfs warnings for device_rename(). > > Renaming network devices to an already existing name is not > something we want sysfs to print a scary warning for, since the > callers can deal with this correctly. So let's introduce > sysfs_create_link_nowarn() which gets rid of the common warning. This patch is unnecessary as that path is never exercised anymore. as: dev_change_name returns early in the case of a noop rename. In addition my introduction sysfs_rename_link handles this case cleanly by first removing the old link and then creating the new link. Preventing false positives when the link names are the same. So it should be safe to drop Cornelia patch without a reoccurance of scary errors. Eric