From: email@example.com (Eric W. Biederman)
To: Pavel Emelyanov <firstname.lastname@example.org>
Cc: Andrew Morton <email@example.com>,
"Eric W. Biederman" <firstname.lastname@example.org>,
Subject: Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
Date: Tue, 04 Dec 2007 05:48:45 -0700 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <475540D9.firstname.lastname@example.org> (Pavel Emelyanov's message of "Tue, 04 Dec 2007 14:58:17 +0300")
Pavel Emelyanov <email@example.com> writes:
>>> We do have some current code in the network stack that fails miserably
>>> when register_sysctl_table returns NULL, and there are explicit
>>> checks for that.
>> So that code would be failing today with CONFIG_SYSCTL=n? Unless the
>> failing code is itself under #ifdef CONFIG_SYSCTL, in which case we don't
>> need to change anything?
> Exactly! If the code checks for the return value it won't work
> with CONFIG_SYSCTL=n, if it dies not - it may happily use the
> sysctl stub and avoid extra ifdefs.
> But this difference looks clumsy :(
So we remove the check as we clean up the code.
Unless we happen to find something that can do something useful and
reasonable is register_sysctl_xxxx fails.
next prev parent reply other threads:[~2007-12-04 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 12:58 [PATCH 0/7] Start using sysctl paths in the core kernel code Pavel Emelyanov
2007-11-30 13:02 ` [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL Pavel Emelyanov
2007-12-03 21:38 ` Andrew Morton
2007-12-03 23:32 ` Eric W. Biederman
2007-12-04 8:58 ` Pavel Emelyanov
2007-12-04 9:23 ` Andrew Morton
2007-12-04 9:31 ` Pavel Emelyanov
2007-12-04 9:45 ` Andrew Morton
2007-12-04 11:40 ` Eric W. Biederman
2007-12-04 11:48 ` Andrew Morton
2007-12-04 11:58 ` Pavel Emelyanov
2007-12-04 12:48 ` Eric W. Biederman [this message]
2007-11-30 13:04 ` [PATCH 2/7][QUOTA] Use sysctl paths to register tables Pavel Emelyanov
2007-11-30 13:09 ` [PATCH 3/7][SYSVIPC] Use the ctl " Pavel Emelyanov
2007-11-30 13:11 ` [PATCH 4/7][SCHED] " Pavel Emelyanov
2007-11-30 13:13 ` [PATCH 5/7][UTS] " Pavel Emelyanov
2007-11-30 13:16 ` [PATCH 6/7][MQUEUE] Move sysctl management code under ifdef CONFIG_SYSCTL Pavel Emelyanov
2007-11-30 13:18 ` [PATCH 7/7][MQUEUE] Use the ctl paths to register tables Pavel Emelyanov
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).